Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nikos/5821/transaction type fix #5856

Merged
merged 7 commits into from
Feb 28, 2023
Merged

Conversation

nikoulai
Copy link
Contributor

Description

closes #5821

Checklist for 1.x:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build with success.
  • I have tested the built dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

@nikoulai nikoulai added the 1.x 1.0 related issues label Feb 22, 2023
@nikoulai nikoulai self-assigned this Feb 22, 2023
@coveralls
Copy link

coveralls commented Feb 22, 2023

Pull Request Test Coverage Report for Build 4292828794

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 271 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+2.4%) to 75.018%

Files with Coverage Reduction New Missed Lines %
packages/web3-core-requestmanager/src/jsonrpc.js 2 64.29%
packages/web3-core-helpers/src/formatters.js 9 83.86%
packages/web3-core-helpers/src/errors.js 29 1.56%
packages/web3-utils/src/soliditySha3.js 34 3.43%
packages/web3-utils/src/index.js 40 40.3%
packages/web3-utils/src/utils.js 46 10.39%
packages/web3-eth-accounts/src/index.js 111 22.94%
Totals Coverage Status
Change from base Build 4279822756: 2.4%
Covered Lines: 3310
Relevant Lines: 4161

💛 - Coveralls

Copy link
Contributor

@jdevcs jdevcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved, and re-triggered build tests, seems these were failing due to time out,.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

About 'Transaction' type definition
5 participants