Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix types default export #5852

Merged

Conversation

shrpne
Copy link

@shrpne shrpne commented Feb 21, 2023

Description

Some packages export their classes as default, but .d.ts definitions don't have default export. So i fixed it by adding export default to .d.ts files

This PR only fixes .d.ts and types tests, so it doesn't affect actual code and can't break anything

Fixes #5543

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist for 1.x:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build with success.
  • I have tested the built dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

@Muhammad-Altabba Muhammad-Altabba changed the base branch from 1.x to fix/5543/web3-has-no-construct-signatures February 23, 2023 13:45
@Muhammad-Altabba Muhammad-Altabba merged commit cf9d49f into web3:fix/5543/web3-has-no-construct-signatures Feb 23, 2023
@Muhammad-Altabba
Copy link
Contributor

Thanks @shrpne for your contribution.
I merged your changes to a feature branch that I created. And then I will create an MR from my branch. This is because for security reasons the GitHub Actions would not be able to run for a community member.

Muhammad-Altabba added a commit that referenced this pull request Feb 27, 2023
Co-authored-by: shrpne <shrpne@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeScript ESM - Web3 has no construct signatures
2 participants