This repository was archived by the owner on Mar 5, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Add optional param hex
to getTransaction
and getBlock
.
#5845
Merged
Muhammad-Altabba
merged 19 commits into
1.x
from
fix/5761/enable-hexToNumber-to-handle-large-numbers
Feb 23, 2023
Merged
Add optional param hex
to getTransaction
and getBlock
.
#5845
Muhammad-Altabba
merged 19 commits into
1.x
from
fix/5761/enable-hexToNumber-to-handle-large-numbers
Feb 23, 2023
+94
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ add helpful exception for wrong inputs + fix some test case.
Pull Request Test Coverage Report for Build 4230254163Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
jdevcs
reviewed
Feb 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
build files indist
should be removed, as these are only included in release PR.
jdevcs
reviewed
Feb 17, 2023
…ttps://github.com/ChainSafe/web3.js into fix/5761/enable-hexToNumber-to-handle-large-numbers
hexToNumber
to return big numbers as stringshex
for getTransaction
and getBlock
.
hex
for getTransaction
and getBlock
.hex
to getTransaction
and getBlock
.
Thanks for this change Muhammad, it looks good. One thing can you update the documentation too, https://web3js.readthedocs.io/en/v1.8.2/web3-utils.html#hextonumber |
…ttps://github.com/ChainSafe/web3.js into fix/5761/enable-hexToNumber-to-handle-large-numbers
nikoulai
approved these changes
Feb 21, 2023
luu-alex
approved these changes
Feb 21, 2023
avkos
suggested changes
Feb 22, 2023
avkos
approved these changes
Feb 23, 2023
Merged
This was referenced Apr 10, 2023
This was referenced Jun 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5761 and #5703 by adding an optional parameter
hex
for bothgetTransaction
andgetBlock
.However, another optional
bigIntOnOverflow
has been added athexToNumber
andtoNumber
only. Which introduces a functionality similar to 4.x for those 2 functions only.Type of change
Checklist for 1.x:
npm run dtslint
with success and extended the tests and types if necessary.npm run test:cov
and my test cases cover all the lines and branches of the added code.npm run build
with success.dist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.Checklist for 4.x:
yarn
successfullyyarn lint
successfullyyarn build:web
successfullyyarn test:unit
successfullyyarn test:integration
successfullycompile:contracts
successfullyCHANGELOG.md
file in the packages I have edited.