Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump util from 0.12.0 to 0.12.5 #5691

Closed
wants to merge 4 commits into from

Conversation

wobsoriano
Copy link

@wobsoriano wobsoriano commented Dec 7, 2022

Description

Bumps web3-core-requestmanager util dependency from v0.12.0 to v0.12.5. Mostly bug and security fixes happened from 0.12.0 to 0.12.5 and should not have any breaking changes. This could also fix the issue #4992.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist for 1.x:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build with success.
  • I have tested the built dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

@wobsoriano wobsoriano changed the title chore(deps): bump util from 0.12.0 to 0.12.4 chore(deps): bump util from 0.12.0 to 0.12.5 Dec 7, 2022
@Muhammad-Altabba Muhammad-Altabba added the 1.x 1.0 related issues label Dec 7, 2022
@luu-alex
Copy link
Contributor

luu-alex commented Dec 8, 2022

Hi there @wobsoriano thanks for the PR it looks good. Can you remove the package-lock.json and dist folder changes? those shouldn't be included

@wobsoriano
Copy link
Author

Done @luu-alex!

@luu-alex
Copy link
Contributor

luu-alex commented Dec 8, 2022

👍

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3646032828

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 436 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-2.3%) to 72.264%

Files with Coverage Reduction New Missed Lines %
packages/web3-core-requestmanager/src/jsonrpc.js 2 82.76%
packages/web3-core-helpers/src/formatters.js 25 80.8%
packages/web3-core-helpers/src/errors.js 31 4.41%
packages/web3-utils/src/soliditySha3.js 55 5.13%
packages/web3-utils/src/index.js 58 36.89%
packages/web3-utils/src/utils.js 96 13.31%
packages/web3-eth-accounts/src/index.js 169 23.26%
Totals Coverage Status
Change from base Build 3642238283: -2.3%
Covered Lines: 3415
Relevant Lines: 4446

💛 - Coveralls

@luu-alex
Copy link
Contributor

luu-alex commented Dec 9, 2022

Thank you for the contribution, it has been merged :) #5700

@luu-alex luu-alex closed this Dec 9, 2022
@wobsoriano wobsoriano deleted the bump-util-0.12.5 branch December 9, 2022 18:31
@jdevcs jdevcs mentioned this pull request Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants