Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.x build failing due to types error #5675

Closed
1 task done
luu-alex opened this issue Dec 2, 2022 · 0 comments
Closed
1 task done

1.x build failing due to types error #5675

luu-alex opened this issue Dec 2, 2022 · 0 comments
Assignees
Labels
1.x 1.0 related issues Bug Addressing a bug

Comments

@luu-alex
Copy link
Contributor

luu-alex commented Dec 2, 2022

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

We ran into issues with package-lock for example with dependancies using different typescript versions.

from my understanding, what is going on is when we run npm run build lerna will hoist all the dependancies meaning all the modules will be a specific version. babel will always be using the latest version of typescript, and when we look at the @types/babel___traverse file we see that type version is 4.1 "typeScriptVersion": "4.1" .

The packages within web3 are all using typescript:'3.9' which will result in an error when index.d.ts is different

Expected Behavior

build should work properly

Steps to Reproduce

pull the latest branch and try to build

Web3.js Version

1.8.1

Environment

  • Operating System:
  • Browser:
  • Node.js Version:
  • NPM Version:

Anything Else?

No response

@luu-alex luu-alex added Bug Addressing a bug 1.x 1.0 related issues labels Dec 2, 2022
@luu-alex luu-alex self-assigned this Dec 2, 2022
@luu-alex luu-alex closed this as completed Dec 2, 2022
@jdevcs jdevcs mentioned this issue Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues Bug Addressing a bug
Projects
None yet
Development

No branches or pull requests

1 participant