core/bloombits: remove old bloombits logic and chain indexer #31081
+80
−2,561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsfelfoldi
requested review from
fjl,
holiman,
karalabe,
gballet,
rjl493456442,
s1na and
lightclient
as code owners
zsfelfoldi
changed the title
zsfelfoldi
force-pushed
the
log-filter-3d
branch
4 times, most recently
from
24cae44 to
99cfa64
Compare
zsfelfoldi
force-pushed
the
log-filter-3d
branch
from
99cfa64 to
a1dd97d
Compare
zsfelfoldi
force-pushed
the
log-filter-3d
branch
4 times, most recently
from
005a47c to
6470cea
Compare
klim0v
reviewed
Mar 17, 2025
eth/ethconfig/config.go
Outdated
| @@ -53,6 +53,7 @@ var Defaults = Config{ | |||
| NetworkId: 0, // enable auto configuration of networkID == chainID | |||
| TxLookupLimit: 2350000, | |||
| TransactionHistory: 2350000, | |||
| LogHistory: 2350000, | |||
There was a problem hiding this comment.
Please do go run github.com/fjl/gencodec -type Config -formats toml -out gen_config.go
|
This needs another rebase now. |
zsfelfoldi
force-pushed
the
log-filter-3d
branch
from
6470cea to
16acc0b
Compare
klim0v
approved these changes
Mar 18, 2025
| @@ -334,6 +335,13 @@ func (f *FilterMaps) init() error { | |||
| return batch.Write() | |||
| } | |||
|
|
|||
| // removeBloomBits removes old bloom bits data from the database. | |||
| func (f *FilterMaps) removeBloomBits() { | |||
There was a problem hiding this comment.
Please relocate the database APIs into the core/rawdb package
zsfelfoldi
force-pushed
the
log-filter-3d
branch
from
16acc0b to
1e99c6e
Compare
zsfelfoldi
force-pushed
the
log-filter-3d
branch
from
1c2cae9 to
d7770b3
Compare
|
I added two trivial fixes to this PR that I think should definitely go into the release. |
fjl
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is #3 of a 3-part series that implements the new log index intended to replace core/bloombits.
Based on #31079 and #31080
Replaces #30370
This part removes the old bloombits package and the chain indexer that was only used by bloombits. Deletes the old bloombits database.
FilterMaps data structure explanation:
https://gist.github.com/zsfelfoldi/a60795f9da7ae6422f28c7a34e02a07e
Log index generator code overview:
https://gist.github.com/zsfelfoldi/97105dff0b1a4f5ed557924a24b9b9e7
Search pattern matcher code overview:
https://gist.github.com/zsfelfoldi/5981735641c956afb18065e84f8aff34
Note that the possibility of a tree hashing scheme and remote proof protocol are mentioned in the documents above but they are not exactly specified yet. These specs are WIP and will be finalized after the local log indexer/filter code is finalized and merged.