eth/fetcher: throttle tx fetches to 128KB responses #28304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holiman
reviewed
Oct 11, 2023
| if _, ok := f.fetching[hash]; !ok { | ||
| // Mark the hash as fetching and stash away possible alternates | ||
| f.fetching[hash] = peer | ||
| // If the transaction is alcear fetching, skip to the next one |
tyler-smith
pushed a commit
to blocknative/go-ethereum
that referenced
this pull request
Oct 12, 2023
* eth/fetcher: throttle tx fetches to 128KB responses * eth/fetcher: unindent a clause per review request
tyler-smith
pushed a commit
to blocknative/go-ethereum
that referenced
this pull request
Oct 16, 2023
* eth/fetcher: throttle tx fetches to 128KB responses * eth/fetcher: unindent a clause per review request
0x366
pushed a commit
to Dexcelerate/go-ethereum
that referenced
this pull request
Nov 8, 2023
* eth/fetcher: throttle tx fetches to 128KB responses * eth/fetcher: unindent a clause per review request
devopsbo3
pushed a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
* eth/fetcher: throttle tx fetches to 128KB responses * eth/fetcher: unindent a clause per review request
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The transaction fetcher until now was rate limited by number of transactions requested. With the addition of announced sizes (and soon arriving blob transactions), we can now also add a throttling on the bandwidth usage. This is needed to avoid requesting too many blob transactions and starving the peer connection due to the response hogging the channel.