Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core, trie: cleanup trie database #28062

Merged
merged 1 commit into from
Sep 7, 2023
Merged

core, trie: cleanup trie database #28062

merged 1 commit into from
Sep 7, 2023

Conversation

rjl493456442
Copy link
Member

@rjl493456442 rjl493456442 commented Sep 5, 2023 •
edited

This PR cleans up the trie database by removing some unused functions and non-interesting field.

holiman
holiman approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HyperDanisH
Copy link

Hi contributors,
I am Danish Arora, a full stack web developer and a go programmer. I have a keen interest in the work you are doing here in this repository and would love to contribute to it, I need some help to begin contributing to this repository. I would ask any one of you to please provide me with an email, discord or any forum where I can have a chat with you. (I really appologize for interupting in between PR, I had really no other way rather than this to communicate with any ethereum core dev.)

Please respond back, It will be aperciated a lot.
Best,

@holiman
Copy link
Contributor

holiman commented Sep 7, 2023

would ask any one of you to please provide me with an email, discord or any forum where I can have a chat with you

There's a link to discord in the main readme, on the frontpage of the repository.

@rjl493456442 rjl493456442 added this to the 1.13.0 milestone Sep 7, 2023
@rjl493456442 rjl493456442 merged commit a7842c9 into ethereum:master Sep 7, 2023
2 checks passed
@rjl493456442 rjl493456442 deleted the cleanup branch September 7, 2023 13:17
devopsbo3 pushed a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@rjl493456442 @devopsbo3
core, trie: cleanup trie database (ethereum#28062)
ef485b7
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@devopsbo3
Revert "core, trie: cleanup trie database (ethereum#28062)"
221f454 
This reverts commit ef485b7.
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@devopsbo3
Revert "core, trie: cleanup trie database (ethereum#28062)"
00c76bb 
This reverts commit ef485b7.
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@devopsbo3
Revert "core, trie: cleanup trie database (ethereum#28062)"
31cf709 
This reverts commit ef485b7.
sduchesneau pushed a commit to streamingfast/go-ethereum that referenced this pull request Feb 26, 2024
@tsahee
Merge upstream PR 28062
1ed9f59 
core, trie: cleanup trie database (ethereum#28062)

 Conflicts:
  core/state/statedb.go
Both us and upstream added fields to the end of StateDb. kept both.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holiman holiman holiman approved these changes

@karalabe karalabe Awaiting requested review from karalabe karalabe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rjl493456442 @HyperDanisH @holiman