core/rawdb: don't warn for missing "unclean shutdown markers" #28014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsvisa
requested review from
karalabe,
holiman and
rjl493456442
as code owners
jsvisa
changed the title
|
Personally I am not sure if it's necessary, mark it as triage to discuss with team. |
|
Triage discussion: let's just delete the warning. THe warning only ever happens when people have cleaned their datadirs, it's not a relevant warning -- it works. |
Signed-off-by: jsvisa <delweng@gmail.com>
Signed-off-by: jsvisa <delweng@gmail.com>
Signed-off-by: jsvisa <delweng@gmail.com>
Signed-off-by: jsvisa <delweng@gmail.com>
This reverts commit 370ad81. Signed-off-by: jsvisa <delweng@gmail.com>
This reverts commit 25733a4. Signed-off-by: jsvisa <delweng@gmail.com>
This reverts commit a456438. Signed-off-by: jsvisa <delweng@gmail.com>
This reverts commit 72e9a72. Signed-off-by: jsvisa <delweng@gmail.com>
…ound" This reverts commit 108adb6. Signed-off-by: jsvisa <delweng@gmail.com>
This reverts commit 340b805. Signed-off-by: jsvisa <delweng@gmail.com>
Signed-off-by: jsvisa <delweng@gmail.com>
jsvisa
force-pushed
the
ethdb-notfound
branch
from
f8aacc2
to
e3f320d
Compare
jsvisa
changed the title
|
I adjusted this PR to remove the warning message only, please take another look @rjl493456442 @holiman |
holiman
changed the title
rjl493456442
approved these changes
Sep 5, 2023
devopsbo3
pushed a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…um#28014) This changes removes the warn-printout about not finding unclean shutdown markers, which always happens on fresh installs / wiped databases.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…ethereum#28014)" This reverts commit f3d4945.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…ethereum#28014)" This reverts commit f3d4945.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…ethereum#28014)" This reverts commit f3d4945.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a new node is run, especially when running with
--devmode, there is always a log below: