Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

geth t8n support cancun fork #27783

Closed
winsvega opened this issue Jul 26, 2023 · 2 comments · Fixed by #27796
Closed

geth t8n support cancun fork #27783

winsvega opened this issue Jul 26, 2023 · 2 comments · Fixed by #27796
Labels
type:feature

Comments

@winsvega
Copy link
Contributor

it looks like geth t8n still does not calculate

in t8n reponse file
"currentExcessDataGas"
"currentDataGasUsed"
in env t8n file
"parentExcessDataGas" (to calculate the formula) or "currentExcessDataGas" (to set the value without formula)
"parentDataGasUsed" (to calculate the formula) or "currentDataGasUsed" (to set the value without formula)
@holiman
Copy link
Contributor

holiman commented Aug 1, 2023

Mostly implemented in #27796. However...
Should currentExcessDataGas be the value that was used during this block (that is, given as input or calculated using the parent values), or should it be the values to be used for a future child block?

@holiman
Copy link
Contributor

holiman commented Aug 1, 2023

Please check it out, I think it behaves logically now

@holiman holiman linked a pull request Aug 1, 2023 that will close this issue
cmd/evm: set ExcessBlobGas from env #27796
Merged
holiman added a commit that referenced this issue Aug 1, 2023
@jsvisa @holiman
cmd/evm: set ExcessBlobGas from env (#27796)
f404a2d 
Sets the `currentExcessBlobGas` from env, alternatively calculates it based on `parentExcessBlobGas` and `parentBlobGasUsed`. It then emits the `currentExcessBlobGas` and `currentBlobGasUsed` into the output, to be used as parent-values for a future iteration. 

Closes #27785
Closes #27783

---------

Signed-off-by: jsvisa <delweng@gmail.com>
Co-authored-by: Martin Holst Swende <martin@swende.se>
MoonShiesty pushed a commit to MoonShiesty/go-ethereum that referenced this issue Aug 30, 2023
@jsvisa @holiman @MoonShiesty
cmd/evm: set ExcessBlobGas from env (ethereum#27796)
d2d9e44 
Sets the `currentExcessBlobGas` from env, alternatively calculates it based on `parentExcessBlobGas` and `parentBlobGasUsed`. It then emits the `currentExcessBlobGas` and `currentBlobGasUsed` into the output, to be used as parent-values for a future iteration. 

Closes ethereum#27785
Closes ethereum#27783

---------

Signed-off-by: jsvisa <delweng@gmail.com>
Co-authored-by: Martin Holst Swende <martin@swende.se>
devopsbo3 pushed a commit to HorizenOfficial/go-ethereum that referenced this issue Nov 10, 2023
@jsvisa @holiman @devopsbo3
cmd/evm: set ExcessBlobGas from env (ethereum#27796)
1680bf1 
Sets the `currentExcessBlobGas` from env, alternatively calculates it based on `parentExcessBlobGas` and `parentBlobGasUsed`. It then emits the `currentExcessBlobGas` and `currentBlobGasUsed` into the output, to be used as parent-values for a future iteration. 

Closes ethereum#27785
Closes ethereum#27783

---------

Signed-off-by: jsvisa <delweng@gmail.com>
Co-authored-by: Martin Holst Swende <martin@swende.se>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cmd/evm: set ExcessBlobGas from env jsvisa/go-ethereum
2 participants
@holiman @winsvega