{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":15452919,"defaultBranch":"master","name":"go-ethereum","ownerLogin":"ethereum","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2013-12-26T13:05:46.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/6250754?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1717169807.0","currentOid":""},"activityList":{"items":[{"before":"2613523cb510a2e3ab956214c447e95c8a3d2d56","after":"d4b81f0e087a660cffcbc6c660b43b46115e62ee","ref":"refs/heads/master","pushedAt":"2024-05-31T16:40:09.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"fjl","name":"Felix Lange","path":"/fjl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6915?s=80&v=4"},"commit":{"message":"CODEOWNERS: @s1na owns core/tracing (#29899)\n\nUpdate CODEOWNERS","shortMessageHtmlLink":"CODEOWNERS: <a class=\"user-mention notranslate\" data-hovercard-type=\"user\" data-hovercard-url=\"/users/s1na/hovercard\" data-octo-click=\"hovercard-link-click\" data-octo-dimensions=\"link_type:self\" href=\"https://github.com/s1na\">@s1na</a> owns core/tracing (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2328108796\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ethereum/go-ethereum/issues/29899\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ethereum/go-ethereum/pull/29899/hovercard\" href=\"https://github.com/ethereum/go-ethereum/pull/29899\">#29899</a>)"}},{"before":null,"after":"62374cdd19855213c45cbd5bb5182f708b4cbd9f","ref":"refs/heads/s1na-patch-2","pushedAt":"2024-05-31T15:36:47.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"s1na","name":"Sina M","path":"/s1na","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1591639?s=80&v=4"},"commit":{"message":"Update CODEOWNERS","shortMessageHtmlLink":"Update CODEOWNERS"}},{"before":"bdc62f9bebc6f0762b77568a421a35125fa7db61","after":"2613523cb510a2e3ab956214c447e95c8a3d2d56","ref":"refs/heads/master","pushedAt":"2024-05-31T07:39:40.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"karalabe","name":"Péter Szilágyi","path":"/karalabe","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/129561?s=80&v=4"},"commit":{"message":"miner: lower default min miner tip from 1 gwei to 0.001 gwei (#29895)","shortMessageHtmlLink":"miner: lower default min miner tip from 1 gwei to 0.001 gwei (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2327067441\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ethereum/go-ethereum/issues/29895\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ethereum/go-ethereum/pull/29895/hovercard\" href=\"https://github.com/ethereum/go-ethereum/pull/29895\">#29895</a>)"}},{"before":"5d7d48fc3e862237f97a9a27ba737816ab641a55","after":"bdc62f9bebc6f0762b77568a421a35125fa7db61","ref":"refs/heads/master","pushedAt":"2024-05-31T07:25:49.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"karalabe","name":"Péter Szilágyi","path":"/karalabe","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/129561?s=80&v=4"},"commit":{"message":"common/math: rename variable name `int` to `n` (#29890)\n\n* chore: rename variable name `int` to `in`\r\n\r\n* chore: rename variable name `int` to `n`","shortMessageHtmlLink":"common/math: rename variable name <code>int</code> to <code>n</code> (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2325757032\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ethereum/go-ethereum/issues/29890\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ethereum/go-ethereum/pull/29890/hovercard\" href=\"https://github.com/ethereum/go-ethereum/pull/29890\">#29890</a>)"}},{"before":"2262bf34158e184a2440f325ad355a45fa15ba9d","after":"5d7d48fc3e862237f97a9a27ba737816ab641a55","ref":"refs/heads/master","pushedAt":"2024-05-30T16:22:23.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"fjl","name":"Felix Lange","path":"/fjl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6915?s=80&v=4"},"commit":{"message":"eth/gasprice: add comment to constant (#29892)\n\n\r\nCo-authored-by: Felix Lange <fjl@twurst.com>","shortMessageHtmlLink":"eth/gasprice: add comment to constant (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2325913617\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ethereum/go-ethereum/issues/29892\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ethereum/go-ethereum/pull/29892/hovercard\" href=\"https://github.com/ethereum/go-ethereum/pull/29892\">#29892</a>)"}},{"before":"e015c1116f2c78a5b140d3fdc368f5d1abcd2eaf","after":"2262bf34158e184a2440f325ad355a45fa15ba9d","ref":"refs/heads/master","pushedAt":"2024-05-30T14:24:16.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"fjl","name":"Felix Lange","path":"/fjl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6915?s=80&v=4"},"commit":{"message":"crypto/secp256k1: change receiver variable name to lowercase (#29889)","shortMessageHtmlLink":"crypto/secp256k1: change receiver variable name to lowercase (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2325554972\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ethereum/go-ethereum/issues/29889\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ethereum/go-ethereum/pull/29889/hovercard\" href=\"https://github.com/ethereum/go-ethereum/pull/29889\">#29889</a>)"}},{"before":"6bb13e8e2be3aa8c41460eb11837baba514e19be","after":"e015c1116f2c78a5b140d3fdc368f5d1abcd2eaf","ref":"refs/heads/master","pushedAt":"2024-05-30T13:23:04.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"rjl493456442","name":null,"path":"/rjl493456442","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5959481?s=80&v=4"},"commit":{"message":"ethdb: remove unnecessary function wrapper (#29888)","shortMessageHtmlLink":"ethdb: remove unnecessary function wrapper (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2325537917\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ethereum/go-ethereum/issues/29888\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ethereum/go-ethereum/pull/29888/hovercard\" href=\"https://github.com/ethereum/go-ethereum/pull/29888\">#29888</a>)"}},{"before":"c6075018f193e10b545f79b128dec28f6aa5479a","after":"214f24be6bf67596207c31d38e2b7287679112ca","ref":"refs/heads/website","pushedAt":"2024-05-29T14:30:49.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"fjl","name":"Felix Lange","path":"/fjl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6915?s=80&v=4"},"commit":{"message":"Add Disclaimer on clique being deprecated from v1.14 (#29878)\n\nadd a disclaimer on each clique mention saying it has been deprecated since version v1.14","shortMessageHtmlLink":"Add Disclaimer on clique being deprecated from v1.14 (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2323329793\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ethereum/go-ethereum/issues/29878\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ethereum/go-ethereum/pull/29878/hovercard\" href=\"https://github.com/ethereum/go-ethereum/pull/29878\">#29878</a>)"}},{"before":"2f06c1e854de1d916547a539679649e359dad476","after":"6bb13e8e2be3aa8c41460eb11837baba514e19be","ref":"refs/heads/master","pushedAt":"2024-05-29T13:56:52.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"fjl","name":"Felix Lange","path":"/fjl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6915?s=80&v=4"},"commit":{"message":"eth/catalyst: ensure TxPool is synced in Fork (#29876)\n\nThis should fix an occasional test failure in ethclient/simulated.TestForkResendTx.\r\nInspection of logs revealed the cause of the failure to be that the txpool was not done\r\nreorganizing by the time Fork is called.","shortMessageHtmlLink":"eth/catalyst: ensure TxPool is synced in Fork (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2323215399\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ethereum/go-ethereum/issues/29876\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ethereum/go-ethereum/pull/29876/hovercard\" href=\"https://github.com/ethereum/go-ethereum/pull/29876\">#29876</a>)"}},{"before":"3fef53447f39878e5ebca1938db90e79a363f535","after":"2f06c1e854de1d916547a539679649e359dad476","ref":"refs/heads/master","pushedAt":"2024-05-29T13:55:51.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"fjl","name":"Felix Lange","path":"/fjl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6915?s=80&v=4"},"commit":{"message":"cmd/devp2p: fix node.TCP -> node.UDP (#29879)","shortMessageHtmlLink":"cmd/devp2p: fix node.TCP -&gt; node.UDP (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2323330554\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ethereum/go-ethereum/issues/29879\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ethereum/go-ethereum/pull/29879/hovercard\" href=\"https://github.com/ethereum/go-ethereum/pull/29879\">#29879</a>)"}},{"before":"94a8b296e4c0abb90e31f35d0fc433869740207d","after":"3fef53447f39878e5ebca1938db90e79a363f535","ref":"refs/heads/master","pushedAt":"2024-05-29T13:31:27.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"karalabe","name":"Péter Szilágyi","path":"/karalabe","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/129561?s=80&v=4"},"commit":{"message":"build: upgrade to golangci-lint v1.59.0 (#29875)","shortMessageHtmlLink":"build: upgrade to golangci-lint v1.59.0 (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2323114762\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ethereum/go-ethereum/issues/29875\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ethereum/go-ethereum/pull/29875/hovercard\" href=\"https://github.com/ethereum/go-ethereum/pull/29875\">#29875</a>)"}},{"before":"e26fa9e40ebddc39247ca11cae28c7f6bd8337e4","after":"94a8b296e4c0abb90e31f35d0fc433869740207d","ref":"refs/heads/master","pushedAt":"2024-05-29T13:02:26.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"fjl","name":"Felix Lange","path":"/fjl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6915?s=80&v=4"},"commit":{"message":"p2p/discover: refactor node and endpoint representation (#29844)\n\nHere we clean up internal uses of type discover.node, converting most code to use\r\nenode.Node instead. The discover.node type used to be the canonical representation of\r\nnetwork hosts before ENR was introduced. Most code worked with *node to avoid conversions\r\nwhen interacting with Table methods. Since *node also contains internal state of Table and\r\nis a mutable type, using *node outside of Table code is prone to data races. It's also\r\ncleaner not having to wrap/unwrap *enode.Node all the time.\r\n\r\ndiscover.node has been renamed to tableNode to clarify its purpose.\r\n\r\nWhile here, we also change most uses of net.UDPAddr into netip.AddrPort. While this is\r\ntechnically a separate refactoring from the *node -> *enode.Node change, it is more\r\nconvenient because *enode.Node handles IP addresses as netip.Addr. The switch to package\r\nnetip in discovery would've happened very soon anyway.\r\n\r\nThe change to netip.AddrPort stops at certain interface points. For example, since package\r\np2p/netutil has not been converted to use netip.Addr yet, we still have to convert to\r\nnet.IP/net.UDPAddr in a few places.","shortMessageHtmlLink":"p2p/discover: refactor node and endpoint representation (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2317622419\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ethereum/go-ethereum/issues/29844\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ethereum/go-ethereum/pull/29844/hovercard\" href=\"https://github.com/ethereum/go-ethereum/pull/29844\">#29844</a>)"}},{"before":"2f0e63e5ac6e1c1c85b5831a19bf7bbd6a63ca1d","after":"e26fa9e40ebddc39247ca11cae28c7f6bd8337e4","ref":"refs/heads/master","pushedAt":"2024-05-29T12:44:14.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"fjl","name":"Felix Lange","path":"/fjl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6915?s=80&v=4"},"commit":{"message":"core/state: fix typo in comment (#29639)","shortMessageHtmlLink":"core/state: fix typo in comment (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2260781444\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ethereum/go-ethereum/issues/29639\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ethereum/go-ethereum/pull/29639/hovercard\" href=\"https://github.com/ethereum/go-ethereum/pull/29639\">#29639</a>)"}},{"before":"06263b1b356dde3e2509aef4efef295744e4f6c3","after":"2f0e63e5ac6e1c1c85b5831a19bf7bbd6a63ca1d","ref":"refs/heads/master","pushedAt":"2024-05-29T12:43:07.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"fjl","name":"Felix Lange","path":"/fjl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6915?s=80&v=4"},"commit":{"message":"eth/downloader, eth/tracer: fix typos in comments (#29707)","shortMessageHtmlLink":"eth/downloader, eth/tracer: fix typos in comments (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2279473376\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ethereum/go-ethereum/issues/29707\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ethereum/go-ethereum/pull/29707/hovercard\" href=\"https://github.com/ethereum/go-ethereum/pull/29707\">#29707</a>)"}},{"before":"773d79a2d381541410b280f354e100e881d49da5","after":"c6075018f193e10b545f79b128dec28f6aa5479a","ref":"refs/heads/website","pushedAt":"2024-05-29T10:36:32.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"fjl","name":"Felix Lange","path":"/fjl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6915?s=80&v=4"},"commit":{"message":"website: improved native-bindings with latest code (#29745)\n\n\r\n\r\nCo-authored-by: Felix Lange <fjl@twurst.com>","shortMessageHtmlLink":"website: improved native-bindings with latest code (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2287606879\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ethereum/go-ethereum/issues/29745\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ethereum/go-ethereum/pull/29745/hovercard\" href=\"https://github.com/ethereum/go-ethereum/pull/29745\">#29745</a>)"}},{"before":"b8cf1636d4af9bf1eaea51294ad78885c4474091","after":"06263b1b356dde3e2509aef4efef295744e4f6c3","ref":"refs/heads/master","pushedAt":"2024-05-29T10:24:10.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"fjl","name":"Felix Lange","path":"/fjl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6915?s=80&v=4"},"commit":{"message":"all: fix typos in comments (#29873)\n\nfix using `a` & `the` simutaneously","shortMessageHtmlLink":"all: fix typos in comments (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2322800385\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ethereum/go-ethereum/issues/29873\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ethereum/go-ethereum/pull/29873/hovercard\" href=\"https://github.com/ethereum/go-ethereum/pull/29873\">#29873</a>)"}},{"before":"ea894dbb47d882629cb6c53708997c91d0362cfc","after":"773d79a2d381541410b280f354e100e881d49da5","ref":"refs/heads/website","pushedAt":"2024-05-29T10:16:43.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"fjl","name":"Felix Lange","path":"/fjl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6915?s=80&v=4"},"commit":{"message":"website: update developer mode tutorial for v1.14.0 (#29752)\n\n* website: update developer mode tutorial for v1.14.0\r\n\r\n* website: update Remix images to reflect current UI","shortMessageHtmlLink":"website: update developer mode tutorial for v1.14.0 (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2290625238\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ethereum/go-ethereum/issues/29752\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ethereum/go-ethereum/pull/29752/hovercard\" href=\"https://github.com/ethereum/go-ethereum/pull/29752\">#29752</a>)"}},{"before":"153f8da8875930d2a7634939595b38c7bf7a6b10","after":"b8cf1636d4af9bf1eaea51294ad78885c4474091","ref":"refs/heads/master","pushedAt":"2024-05-29T10:12:57.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"fjl","name":"Felix Lange","path":"/fjl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6915?s=80&v=4"},"commit":{"message":"accounts: fix TestUpdateKeyfileContents (#29867)\n\nCreate the directory before NewKeyStore. This ensures the watcher successfully starts on\r\nthe first attempt, and waitWatcherStart functions as intended.","shortMessageHtmlLink":"accounts: fix TestUpdateKeyfileContents (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2321753341\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ethereum/go-ethereum/issues/29867\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ethereum/go-ethereum/pull/29867/hovercard\" href=\"https://github.com/ethereum/go-ethereum/pull/29867\">#29867</a>)"}},{"before":"daf4f720770d7f7e99fee02f26eb08607d8ddc79","after":"153f8da8875930d2a7634939595b38c7bf7a6b10","ref":"refs/heads/master","pushedAt":"2024-05-29T10:11:18.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"fjl","name":"Felix Lange","path":"/fjl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6915?s=80&v=4"},"commit":{"message":"p2p/nodestate: remove unused package (#29872)","shortMessageHtmlLink":"p2p/nodestate: remove unused package (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2322791898\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ethereum/go-ethereum/issues/29872\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ethereum/go-ethereum/pull/29872/hovercard\" href=\"https://github.com/ethereum/go-ethereum/pull/29872\">#29872</a>)"}},{"before":"5534c849b6f426604a572d54d65a209df42a047a","after":"daf4f720770d7f7e99fee02f26eb08607d8ddc79","ref":"refs/heads/master","pushedAt":"2024-05-29T10:09:58.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"fjl","name":"Felix Lange","path":"/fjl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6915?s=80&v=4"},"commit":{"message":"p2p/simulations: remove stale information about docker adapter (#29874)","shortMessageHtmlLink":"p2p/simulations: remove stale information about docker adapter (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2322812014\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ethereum/go-ethereum/issues/29874\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ethereum/go-ethereum/pull/29874/hovercard\" href=\"https://github.com/ethereum/go-ethereum/pull/29874\">#29874</a>)"}},{"before":"cc22e0cdf0468947265883921b0c29119ca0327a","after":"5534c849b6f426604a572d54d65a209df42a047a","ref":"refs/heads/master","pushedAt":"2024-05-29T08:30:25.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"karalabe","name":"Péter Szilágyi","path":"/karalabe","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/129561?s=80&v=4"},"commit":{"message":"go.mod: update a number of dependencies (#29763)\n\n* deps: update go-winio\r\n\r\n* deps: update fastcache\r\n\r\n* deps: update golang-set\r\n\r\n* update fatih/color\r\n\r\n* update natefinch/lumberjack.v2","shortMessageHtmlLink":"go.mod: update a number of dependencies (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2292355126\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ethereum/go-ethereum/issues/29763\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ethereum/go-ethereum/pull/29763/hovercard\" href=\"https://github.com/ethereum/go-ethereum/pull/29763\">#29763</a>)"}},{"before":"171430c3f5d474327bc1721c7c36ad83ad21b4b2","after":"cc22e0cdf0468947265883921b0c29119ca0327a","ref":"refs/heads/master","pushedAt":"2024-05-28T19:30:17.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"fjl","name":"Felix Lange","path":"/fjl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6915?s=80&v=4"},"commit":{"message":"p2p/discover: fix update logic in handleAddNode (#29836)\n\nIt seems the semantic differences between addFoundNode and addInboundNode were lost in\r\n#29572. My understanding is addFoundNode is for a node you have not contacted directly\r\n(and are unsure if is available) whereas addInboundNode is for adding nodes that have\r\ncontacted the local node and we can verify they are active.\r\n\r\nhandleAddNode seems to be the consolidation of those two methods, yet it bumps the node in\r\nthe bucket (updating it's IP addr) even if the node was not an inbound. This PR fixes\r\nthis. It wasn't originally caught in tests like TestTable_addSeenNode because the\r\nmanipulation of the node object actually modified the node value used by the test.\r\n\r\nNew logic is added to reject non-inbound updates unless the sequence number of the\r\n(signed) ENR increases. Inbound updates, which are published by the updated node itself,\r\nare always accepted. If an inbound update changes the endpoint, the node will be\r\nrevalidated on an expedited schedule.\r\n\r\nCo-authored-by: Felix Lange <fjl@twurst.com>","shortMessageHtmlLink":"p2p/discover: fix update logic in handleAddNode (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2316285357\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ethereum/go-ethereum/issues/29836\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ethereum/go-ethereum/pull/29836/hovercard\" href=\"https://github.com/ethereum/go-ethereum/pull/29836\">#29836</a>)"}},{"before":"e517183719dab4214aa74a9a19ff005ab77c36e1","after":"171430c3f5d474327bc1721c7c36ad83ad21b4b2","ref":"refs/heads/master","pushedAt":"2024-05-28T17:54:55.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"fjl","name":"Felix Lange","path":"/fjl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6915?s=80&v=4"},"commit":{"message":"core/state: remove unused error from prefetcher trie method (#29768)\n\nCo-authored-by: Gary Rong <garyrong0905@gmail.com>\r\nCo-authored-by: Felix Lange <fjl@twurst.com>","shortMessageHtmlLink":"core/state: remove unused error from prefetcher trie method (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2294283015\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ethereum/go-ethereum/issues/29768\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ethereum/go-ethereum/pull/29768/hovercard\" href=\"https://github.com/ethereum/go-ethereum/pull/29768\">#29768</a>)"}},{"before":"af0a3274be0f948f4816142394559f2d02475980","after":"e517183719dab4214aa74a9a19ff005ab77c36e1","ref":"refs/heads/master","pushedAt":"2024-05-28T17:52:08.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"fjl","name":"Felix Lange","path":"/fjl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6915?s=80&v=4"},"commit":{"message":" eth, eth/downloader: remove references to LightChain, LightSync (#29711)\n\n\r\nCo-authored-by: Gary Rong <garyrong0905@gmail.com>","shortMessageHtmlLink":" eth, eth/downloader: remove references to LightChain, LightSync (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2280001059\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ethereum/go-ethereum/issues/29711\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ethereum/go-ethereum/pull/29711/hovercard\" href=\"https://github.com/ethereum/go-ethereum/pull/29711\">#29711</a>"}},{"before":"b88051ec83bba7882b59ab9cee573a9c111063e9","after":"af0a3274be0f948f4816142394559f2d02475980","ref":"refs/heads/master","pushedAt":"2024-05-28T16:13:03.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"fjl","name":"Felix Lange","path":"/fjl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6915?s=80&v=4"},"commit":{"message":"p2p/discover: fix crash when revalidated node is removed (#29864)\n\nIn #29572, I assumed the revalidation list that the node is contained in could only ever\r\nbe changed by the outcome of a revalidation request. But turns out that's not true: if the\r\nnode gets removed due to FINDNODE failure, it will also be removed from the list it is in.\r\nThis causes a crash.\r\n\r\nThe invariant is: while node is in table, it is always in exactly one of the two lists. So\r\nit seems best to store a pointer to the current list within the node itself.","shortMessageHtmlLink":"p2p/discover: fix crash when revalidated node is removed (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2320750733\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ethereum/go-ethereum/issues/29864\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ethereum/go-ethereum/pull/29864/hovercard\" href=\"https://github.com/ethereum/go-ethereum/pull/29864\">#29864</a>)"}},{"before":"61932e47106168a4eeb93ee68211752a25e031c5","after":"b88051ec83bba7882b59ab9cee573a9c111063e9","ref":"refs/heads/master","pushedAt":"2024-05-28T12:41:11.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"fjl","name":"Felix Lange","path":"/fjl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6915?s=80&v=4"},"commit":{"message":"core/rawdb, triedb/pathdb: fix freezer read-only option (#29823)","shortMessageHtmlLink":"core/rawdb, triedb/pathdb: fix freezer read-only option (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2312174849\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ethereum/go-ethereum/issues/29823\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ethereum/go-ethereum/pull/29823/hovercard\" href=\"https://github.com/ethereum/go-ethereum/pull/29823\">#29823</a>)"}},{"before":"871e55d93e8b0aeb85c71eff4adf1460547b01d0","after":"61932e47106168a4eeb93ee68211752a25e031c5","ref":"refs/heads/master","pushedAt":"2024-05-28T12:16:45.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"fjl","name":"Felix Lange","path":"/fjl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6915?s=80&v=4"},"commit":{"message":"cmd/geth: update testdata (vulncheck) (#29714)","shortMessageHtmlLink":"cmd/geth: update testdata (vulncheck) (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2280879777\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ethereum/go-ethereum/issues/29714\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ethereum/go-ethereum/pull/29714/hovercard\" href=\"https://github.com/ethereum/go-ethereum/pull/29714\">#29714</a>)"}},{"before":"42471d7a3e78296ed99b3d9ac804385931f80ec5","after":"871e55d93e8b0aeb85c71eff4adf1460547b01d0","ref":"refs/heads/master","pushedAt":"2024-05-28T12:10:27.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"fjl","name":"Felix Lange","path":"/fjl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6915?s=80&v=4"},"commit":{"message":"core/state: fix typos in comments (#29767)","shortMessageHtmlLink":"core/state: fix typos in comments (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2294254838\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ethereum/go-ethereum/issues/29767\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ethereum/go-ethereum/pull/29767/hovercard\" href=\"https://github.com/ethereum/go-ethereum/pull/29767\">#29767</a>)"}},{"before":"caafa93598927303d8dbe0aa53bf43ca08632805","after":"42471d7a3e78296ed99b3d9ac804385931f80ec5","ref":"refs/heads/master","pushedAt":"2024-05-28T11:45:16.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"fjl","name":"Felix Lange","path":"/fjl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6915?s=80&v=4"},"commit":{"message":"core/vm/runtime: set random to enable merge-opcodes (#29799)","shortMessageHtmlLink":"core/vm/runtime: set random to enable merge-opcodes (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2302358653\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ethereum/go-ethereum/issues/29799\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ethereum/go-ethereum/pull/29799/hovercard\" href=\"https://github.com/ethereum/go-ethereum/pull/29799\">#29799</a>)"}},{"before":"ea6c16007c30468ad92c45a13ba1d74514f2d9cf","after":"caafa93598927303d8dbe0aa53bf43ca08632805","ref":"refs/heads/master","pushedAt":"2024-05-28T11:44:40.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"fjl","name":"Felix Lange","path":"/fjl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6915?s=80&v=4"},"commit":{"message":"all: improve some error strings (#29842)","shortMessageHtmlLink":"all: improve some error strings (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2317548622\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ethereum/go-ethereum/issues/29842\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ethereum/go-ethereum/pull/29842/hovercard\" href=\"https://github.com/ethereum/go-ethereum/pull/29842\">#29842</a>)"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEWTkvPgA","startCursor":null,"endCursor":null}},"title":"Activity · ethereum/go-ethereum"}