Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use ci-builder image for slither #9624

Merged
merged 2 commits into from
Feb 22, 2024
Merged

Conversation

mds1
Copy link
Contributor

@mds1 mds1 commented Feb 22, 2024

Updates the slither github action to use CI builder, so our pinned version of foundry is used, instead of the latest version.

@ethereum-optimism/contract-reviewers Please note that now when updating the CI builder image in .circleci/config.yml we'll also need to update it here

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@mds1 mds1 requested a review from a team as a code owner February 22, 2024 15:48
@mds1 mds1 requested a review from tynes February 22, 2024 15:48
Copy link
Contributor

coderabbitai bot commented Feb 22, 2024

Walkthrough

Walkthrough

The update involves transitioning the CI workflow's execution environment from the default ubuntu-latest runner to a specific Docker image, us-docker.pkg.dev/oplabs-tools-artifacts/images/ci-builder:v0.43.0. This change aims to enhance standardization and potentially provide better control and consistency during CI runs.

Changes

File Path Change Summary
.github/workflows/slither.yml Switched execution environment to us-docker.pkg.dev/oplabs-tools-artifacts/images/ci-builder:v0.43.0

Related issues

  • ci: add docker CLI to ci-builder image #8529: This PR demonstrates a proactive approach by incorporating essential tools (like Docker CLI) directly into the ci-builder image, aligning with the suggestion to enrich the CI environment by integrating more tools into the ci-builder image itself.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@mds1
Copy link
Contributor Author

mds1 commented Feb 22, 2024

Hm maybe this didn't work? Seems the slither-analyze job is stuck, cc @raffaele-oplabs image

Switching PR to draft in the meantime

@mds1 mds1 marked this pull request as draft February 22, 2024 18:11
@mds1 mds1 marked this pull request as ready for review February 22, 2024 20:02
@mds1
Copy link
Contributor Author

mds1 commented Feb 22, 2024

Ok this is working as expected, now thanks @raffaele-oplabs!

@mds1 mds1 added this pull request to the merge queue Feb 22, 2024
Merged via the queue into develop with commit af1d482 Feb 22, 2024
71 checks passed
@mds1 mds1 deleted the ci/use-ci-builder-for-slither branch February 22, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants