Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store cannon-go-lint-and-test logs on failure #10055

Merged
merged 7 commits into from Apr 5, 2024
Merged

Conversation

trianglesphere
Copy link
Contributor

@trianglesphere trianglesphere commented Apr 5, 2024

Description

I also switched to quiet logs to help this test pass. Otherwise it was randomly failing after dumping out a huge amount of logs. If a test fails, it will log & then the logs will be saved for further inspection.

Needed to debug why this test is failing
@trianglesphere trianglesphere requested a review from a team as a code owner April 5, 2024 15:44
@ethereum-optimism ethereum-optimism deleted a comment from coderabbitai bot Apr 5, 2024
Copy link
Contributor

coderabbitai bot commented Apr 5, 2024

Warning

Rate Limit Exceeded

@trianglesphere has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 24 minutes and 59 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between bb97d6b and 1a0d0d4.

Walkthrough

The recent update to the CI/CD pipeline configuration in CircleCI introduces the store_artifacts step, enhancing logging by preserving logs in the /testlogs directory upon test failures.

Changes

File(s) Summary of Changes
.circleci/config.yml Added store_artifacts step to save logs in /testlogs on test failures.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.05%. Comparing base (d5b1b75) to head (1a0d0d4).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #10055      +/-   ##
===========================================
+ Coverage    42.40%   51.05%   +8.65%     
===========================================
  Files           73       69       -4     
  Lines         4830     3753    -1077     
  Branches       766      567     -199     
===========================================
- Hits          2048     1916     -132     
+ Misses        2676     1806     -870     
+ Partials       106       31      -75     
Flag Coverage Δ
cannon-go-tests 82.29% <ø> (ø)
chain-mon-tests 27.14% <ø> (ø)
common-ts-tests 26.72% <ø> (ø)
contracts-ts-tests ?
core-utils-tests 44.03% <ø> (ø)
sdk-tests 40.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

.circleci/config.yml Outdated Show resolved Hide resolved
@trianglesphere trianglesphere added this pull request to the merge queue Apr 5, 2024
Merged via the queue into develop with commit 7a37628 Apr 5, 2024
71 of 73 checks passed
@trianglesphere trianglesphere deleted the jg/circle_ci branch April 5, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants