Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Register Asterisc to AnchorStateRegistry for devnet #10050

Conversation

pcw109550
Copy link
Contributor

@pcw109550 pcw109550 commented Apr 4, 2024

Description

Registers asterisc anchorState to AnchorStateRegistry. Did not touch FPAC deployment scripts to not alter live deployments.

Tests

Tweaked AnchorStateRegistry.t.sol:: AnchorStateRegistry_Initialize_Test for checking that AnchorStateRegistry correctly loads default devnet root and block number.

Copy link
Contributor

coderabbitai bot commented Apr 4, 2024

Walkthrough

Walkthrough

The update involves expanding the Deploy contract to accommodate an additional game type, ASTERISC, by increasing the array size for roots and adding a new element. Additionally, the AnchorStateRegistry contract's test suite is enhanced to include this new anchor type, ensuring its root hash and L2 block number are correctly asserted. This expansion reflects an effort to support more game types within the system.

Changes

Files Change Summary
.../scripts/Deploy.s.sol
.../test/dispute/AnchorStateRegistry.t.sol
Increased roots array size from 3 to 4 in Deploy contract and added GameTypes.ASTERISC at index 3. Added ASTERISC anchor type in tests for AnchorStateRegistry with assertions for its root hash and L2 block number.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@pcw109550 pcw109550 force-pushed the tip/pcw109550/register-asterisc-to-anchorstateregistry branch from 7875392 to e20eb76 Compare April 4, 2024 21:42
@Inphi Inphi added this pull request to the merge queue Apr 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 4, 2024
@Inphi Inphi added this pull request to the merge queue Apr 4, 2024
Merged via the queue into ethereum-optimism:develop with commit 211f9e4 Apr 4, 2024
66 checks passed
pcw109550 added a commit to ethereum-optimism/asterisc that referenced this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants