Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.5] Add govuln GitHub workflow #17550

Merged

Conversation

ivanvc
Copy link
Member

@ivanvc ivanvc commented Mar 7, 2024

Enables govuln in the release-3.5 branch.

Part of #17549.

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

@k8s-ci-robot
Copy link

Hi @ivanvc. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@liangyuanpeng liangyuanpeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - New workflow is now correctly picking up the recent CVE affecting release-3.5.

This is a good signal to have for the stable release branches, thanks @ivanvc.

@ivanvc
Copy link
Member Author

ivanvc commented Mar 8, 2024

LGTM - New workflow is now correctly picking up the recent CVE affecting release-3.5.

This is a good signal to have for the stable release branches, thanks @ivanvc.

Would it make sense to also enable it as a nightly job for these branches?

@ahrtr
Copy link
Member

ahrtr commented Mar 8, 2024

Thanks for the fix.

Please rebase this PR.

Would it make sense to also enable it as a nightly job for these branches?

Adding a workflow being triggered on each PR might be good enough for now. If we all agree to do it, then let's add a nightly for main, 3.5 and 3.4.

Signed-off-by: Ivan Valdes <ivan@vald.es>
@ivanvc ivanvc force-pushed the release-3.5-add-govuln-github-workflow branch from 49c7b2f to 67afad6 Compare March 8, 2024 16:30
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Thanks

@ahrtr ahrtr merged commit d0a0281 into etcd-io:release-3.5 Mar 8, 2024
18 checks passed
@ivanvc ivanvc deleted the release-3.5-add-govuln-github-workflow branch March 8, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

5 participants