Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.5] mvcc: Printing etcd backend database related metrics inside scheduleCompaction function #17291

Merged
merged 1 commit into from Jan 23, 2024

Conversation

rahulbapumore
Copy link
Contributor

Backporting commit 21bbc82 in etcd 3.5
To improve traceability of backend database usage, Added below parameter related to backend database usage metrics inside scheduledCompaction function.
current-db-size-bytes
current-db-size
current-db-size-in-use-bytes
current-db-size-in-use

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

…ompaction function

Backporting commit 21bbc82 in etcd 3.5
To improve traceability of backend database usage, Added below parameter
related to backend database usage metrics inside scheduledCompaction
function.
current-db-size-bytes
current-db-size
current-db-size-in-use-bytes
current-db-size-in-use

Signed-off-by: Rahul More <rahulbapumore@gmail.com>
@k8s-ci-robot
Copy link

Hi @rahulbapumore. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rahulbapumore
Copy link
Contributor Author

Hi @ahrtr ,
Could you please have a look at this pull request?

Thanks

@ahrtr ahrtr changed the title mvcc: Printing etcd backend database related metrics inside scheduleCompaction function [3.5] mvcc: Printing etcd backend database related metrics inside scheduleCompaction function Jan 22, 2024
@ahrtr
Copy link
Member

ahrtr commented Jan 22, 2024

Backporting #17204

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Thanks

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Given this touches log output we should probably add to 3.5 changelog once merged

@ahrtr ahrtr merged commit c7bcb5f into etcd-io:release-3.5 Jan 23, 2024
15 checks passed
@rahulbapumore
Copy link
Contributor Author

Hi @ahrtr ,
Just a question
What would be the target version for this change and any timeline for it?

Thanks

@ahrtr
Copy link
Member

ahrtr commented Jan 23, 2024

What would be the target version

3.5.12

any timeline for it

Not finalised yet. But I think roughly in 1 ~ 2 months

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants