fix: add check that the readme sample cfg is accepted by log4rs #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #339 +/- ##
==========================================
+ Coverage 61.12% 62.10% +0.97%
==========================================
Files 23 23
Lines 1407 1409 +2
==========================================
+ Hits 860 875 +15
+ Misses 547 534 -13 ☔ View full report in Codecov by Sentry. |
estk
approved these changes
Jan 23, 2024
bconn98
added a commit
to bconn98/log4rs
that referenced
this pull request
Jan 24, 2024
…#339) * fix: add check that the readme sample cfg is accepted by log4rs * fix: add new create_raw_config function to allow for usage in tests * chore: self review cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #334