- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add trigger kind "time" in rolling_file #296
Conversation
I modified the trigger logic again. Now, assuming the trigger time is 2 days, a new log file will be generated at 0:00 every other day, even though the first trigger may be less than 2 days. The same applies to others. |
With time based trigger you might want to add the pattern for the window to allow the time and date the file was created. |
fbb654b
to
8965543
Compare
I suggest that whether the log get written pre or post roll should be configurable. Lets make the logic dependent on the roller. |
Doc wasn't competed yet. |
I added a config item in roller called |
9cb39f7
to
859bf93
Compare
6878bf6
to
dddbcf3
Compare
The changes are as follows
I don't use the |
Co-authored-by: Bryan Conn <30739012+bconn98@users.noreply.github.com>
Co-authored-by: Bryan Conn <30739012+bconn98@users.noreply.github.com>
Co-authored-by: Bryan Conn <30739012+bconn98@users.noreply.github.com>
Co-authored-by: Bryan Conn <30739012+bconn98@users.noreply.github.com>
Co-authored-by: Bryan Conn <30739012+bconn98@users.noreply.github.com>
6c11f4d
to
58b779d
Compare
There are two differences between
Any thoughts? |
I'm good with both of those trade offs |
I'll re-review tomorrow |
Co-authored-by: Bryan Conn <30739012+bconn98@users.noreply.github.com>
I add the trigger kind "time" in rolling_file. It can be set with limit like 5second, 10minute, 1day, 3weeks...It may be able to solve the Issue #235. I referred to #139 and thank for @SSebo