Create an example of logging with file rotation

[c-git]

I've also added a small snippet at the bottom to generate log message. I can remove this if it is not desirable

[c-git]

Was there something more I needed to do on this? Sorry I don't remember.

[bconn98]

@c-git Can you please rebase and add your example to the Cargo.toml

[c-git]

I didn't mean to request reviews I just clicked update. Haven't quite figured out how to also do the edit from my phone. If I don't figure it out I'll do it after the holidays when I'm back on my computer.

[bconn98]

No worries, just happened to take a look. If you could also fix the magic numbers that'd be great

[c-git]

I moved the configurable parts of the demo to the top of the file (I hope those are the numbers you were referring to).

I don't know which features are required to be included in the Cargo.toml. I tried none and it worked when I ran cargo run --example log_to_file_with_rolling so I don't know if I'm testing it wrong. But I checked the docs and guessed which would be needed.

[bconn98]

Your testing was correct, because all of the features you're using are part of the default list you technically do not need to list any features. However, it's following convention to list them out so it looks good.

[c-git]

Let me know if there is anything else I need to do?

[bconn98]

No actions from me. I'll see what I can do

[bconn98]

@c-git Please resolve the conflicts, then we are good to go.

[c-git]

I think I fixed it but did it from the GitHub UI so not quite sure but it doesn't show the conflict anymore

[c-git]

Sorry about that, I'll try to see if I can open up more context next time. Seems like an obvious mistake in hindsight.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b0ad8ba) 61.77% compared to head (f953789) 61.77%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #295   +/-   ##
=======================================
  Coverage   61.77%   61.77%           
=======================================
  Files          23       23           
  Lines        1431     1431           
=======================================
  Hits          884      884           
  Misses        547      547           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bconn98]

@c-git Just need you to fix that CI job

[c-git]

Ok I'll try to check it. Will probably be tomorrow night.

[c-git]

Ok I think I fixed it I ran cargo +nightly fmt and committed those changes

[bconn98]

@c-git, hey the MSRV needs to get bumped to support the toml crate. Here is a commit making the same change.

[c-git]

@c-git, hey the MSRV needs to get bumped to support the toml crate. Here is a commit making the same change.

Hey @bconn98 I'm a bit lost. I don't follow the connection between the example in this PR and the toml crate. What do you need me to do?

[bconn98]

The CI/CD pipeline will fail. There was a non major revision change to one of the toml libraries that increased the MSRV to 1.69. When that tries to build in our pipelines with 1.67 it will fail. Therefore, nothing right now can be merged down to main without the fix.