Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codespell: config, workflow (to alert when new typos added) and get typos fixed #247

Merged
merged 4 commits into from
Dec 13, 2023

Conversation

yarikoptic
Copy link
Contributor

feel free to ignore/close

@estesp
Copy link
Owner

estesp commented Dec 13, 2023

I'm fine adding this; definitely seems reasonable, but will need all 4 commits edited to add Signed-off-by: to pass CI. Thanks!

@yarikoptic
Copy link
Contributor Author

force pushed signed off

.codespellrc Outdated
[codespell]
skip = .git,*.pdf,*.svg,go.sum,.codespellrc,vendor
check-hidden = true
# ignore-regex =
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git whitespace checks complaining about an extra space after the = on line 4.

You should be able to verify with: git show --check 045a8a04e6354ac102b4ad8a46857e5c8d988edd

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, fixed, rewritten (why to breed commits) and force pushed after re-signing-off

Signed-off-by: Yaroslav Halchenko <debian@onerussian.com>
Signed-off-by: Yaroslav Halchenko <debian@onerussian.com>
Signed-off-by: Yaroslav Halchenko <debian@onerussian.com>
=== Do not change lines below ===
{
 "chain": [],
 "cmd": "codespell -w",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^

Signed-off-by: Yaroslav Halchenko <debian@onerussian.com>
@estesp estesp merged commit 29c4cb6 into estesp:main Dec 13, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants