fix: Update types and apply to all rules #86
Merged
+120
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fasttime
reviewed
Mar 13, 2025
package.json
Outdated
| @@ -76,6 +76,7 @@ | |||
| "@eslint/core": "^0.12.0", | |||
| "@eslint/plugin-kit": "^0.2.7", | |||
| "@humanwhocodes/momoa": "^3.3.4", | |||
| "momoa": "^1.2.0", | |||
There was a problem hiding this comment.
This seems unnecessary, this repo only uses @humanwhocodes/momoa, which is already installed.
There was a problem hiding this comment.
Oops good catch! That's actually a completely different and unrelated package.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Updates types throughout.
What changes did you make? (Give an overview)
src/rules/no-duplicate-keys.js: Changed the rule definition to use aconst ruleand exported it separately. [1] [2]src/rules/no-empty-keys.js: Changed the rule definition to use aconst ruleand exported it separately. [1] [2]src/rules/no-unnormalized-keys.js: Added type definitions and changed the rule definition to use aconst rule, exporting it separately. [1] [2] [3]src/rules/no-unsafe-values.js: Changed the rule definition to use aconst ruleand exported it separately. [1] [2]src/rules/sort-keys.js: Added type definitions, imports, and helper functions. Changed the rule definition to use aconst ruleand exported it separately. [1] [2] [3] [4]src/rules/top-level-interop.js: Added type definitions and changed the rule definition to use aconst rule, exporting it separately. [1] [2]package.json: Added themomoadependency.src/types.ts: Added comments and lines properties to theIJSONSourceCodeinterface.Related Issues
Is there anything you'd like reviewers to focus on?
I had to reformat the rules because the previous format of applying a type to the default export could only be accomplished with parentheses, and then Prettier would remove the parentheses on precommit.