Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update missing plugin message template #19445

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

mdjermanovic
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

Follow-up to #19402.

The output lists common causes of the problem, but doesn't say what the problem is:

Oops! Something went wrong! :(

ESLint: 9.20.1

Common causes of this problem include:

1. The "foo" plugin is not defined in your configuration file.
2. The "foo" plugin is not defined within the same configuration object in which the "foo/bar" rule is applied.

What changes did you make? (Give an overview)

Added a line describing the problem:

Oops! Something went wrong! :(

ESLint: 9.20.1

A configuration object specifies rule "foo/bar", but could not find plugin "foo".

Common causes of this problem include:

1. The "foo" plugin is not defined in your configuration file.
2. The "foo" plugin is not defined within the same configuration object in which the "foo/bar" rule is applied.

Is there anything you'd like reviewers to focus on?

Sorry, something went wrong.

@mdjermanovic mdjermanovic requested a review from a team as a code owner February 20, 2025 12:12
@eslint-github-bot eslint-github-bot bot added the chore This change is not user-facing label Feb 20, 2025
Copy link

netlify bot commented Feb 20, 2025

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit 7c73357
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/67b71c40d12fbb00077bf145

@fasttime fasttime added the accepted There is consensus among the team that this change meets the criteria for inclusion label Feb 20, 2025
@fasttime
Copy link
Member

fasttime commented Feb 20, 2025

It looks like some checks are still pending, probably a temporary issue with Netlify or GitHub.

image

@fasttime
Copy link
Member

LGTM, but is the tag chore: intended? This change will be visible to users.

@mdjermanovic
Copy link
Member Author

LGTM, but is the tag chore: intended? This change will be visible to users

dab5478 was chore:, but yes I think this should be at least fix:.

@mdjermanovic mdjermanovic changed the title chore: update missing plugin message template fix: update missing plugin message template Feb 20, 2025
@eslint-github-bot eslint-github-bot bot added the bug ESLint is working incorrectly label Feb 20, 2025
@mdjermanovic
Copy link
Member Author

I'll close-reopen to see if that will fix the checks.

@mdjermanovic
Copy link
Member Author

Nope, those two checks are still pending. I think it's safe to merge regardless.

@fasttime fasttime added core Relates to ESLint's core APIs and features and removed chore This change is not user-facing labels Feb 20, 2025
@fasttime fasttime merged commit db5340d into main Feb 20, 2025
50 of 52 checks passed
@fasttime fasttime deleted the update-missing-plugin-template branch February 20, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly core Relates to ESLint's core APIs and features
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

None yet

2 participants