Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove name from eslint/js packages #18368

Merged
merged 1 commit into from Apr 19, 2024
Merged

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Apr 19, 2024

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Partially reverts 4d11e56 - removes names from eslint:recommended and eslint:all. These configs are also used for eslintrc compatibility, which does not support name.

Is there anything you'd like reviewers to focus on?

@nzakas nzakas requested a review from a team as a code owner April 19, 2024 20:36
@eslint-github-bot eslint-github-bot bot added the bug ESLint is working incorrectly label Apr 19, 2024
Copy link

netlify bot commented Apr 19, 2024

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit 37f0f85
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/6622d5d6f2610f000885063f

Copy link
Member

@fasttime fasttime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Waiting for the CI build to finish.

@fasttime fasttime merged commit 8d18958 into main Apr 19, 2024
18 checks passed
@fasttime fasttime deleted the eslint-js-config-fix branch April 19, 2024 20:46
@fasttime fasttime mentioned this pull request Apr 19, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ESLint is working incorrectly
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

None yet

2 participants