Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade knip #18272

Merged
merged 2 commits into from Apr 5, 2024
Merged

chore: upgrade knip #18272

merged 2 commits into from Apr 5, 2024

Conversation

webpro
Copy link
Contributor

@webpro webpro commented Apr 5, 2024

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

After adding support for exports.key = value (next to module.exports), Knip's integration tests against ESLint failed, since the ESLint codebase contains a few instances of exports (without module.) that are written in the ambiguous CommonJS style that Knip considers an issue (wrote about this when introducing Knip here: https://knip.dev/guides/commonjs).

What changes did you make? (Give an overview)

  • Upgrade Knip to the version that adds supports for exports.key = value syntax
  • Refactored the instances that are ambiguous in terms of default vs named imports/exports.

Is there anything you'd like reviewers to focus on?

Not really, but for the sake of completeness:

@webpro webpro requested a review from a team as a code owner April 5, 2024 05:35
@eslint-github-bot eslint-github-bot bot added the chore This change is not user-facing label Apr 5, 2024
@github-actions github-actions bot added the core Relates to ESLint's core APIs and features label Apr 5, 2024
Copy link

netlify bot commented Apr 5, 2024

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit 533fcd2
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/660f953953811c00081d1cb3

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic added accepted There is consensus among the team that this change meets the criteria for inclusion contributor pool labels Apr 5, 2024
@mdjermanovic mdjermanovic merged commit 44a81c6 into eslint:main Apr 5, 2024
18 checks passed
@webpro webpro deleted the upgrade-knip branch April 5, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion chore This change is not user-facing contributor pool core Relates to ESLint's core APIs and features
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

None yet

2 participants