New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add info about dot files and dir in flat config #18239
Conversation
✅ Deploy Preview for docs-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was mentioned in the migration guide , I'm 👍 to add it(if it helps.)
i flat config
a typo in the title. (should be in flat config
?)
@@ -173,6 +173,8 @@ This configuration specifies that all of the files in the `.config` directory sh | |||
|
|||
For more information on configuring rules, see [Ignore Files](ignore). | |||
|
|||
**Note:** Unlike legecy config, by default flat config doesn't ignore files or directories having a name starts with a dot, such as `.fileName` or `.directoryName`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit of cleanup:
**Note:** Unlike legecy config, by default flat config doesn't ignore files or directories having a name starts with a dot, such as `.fileName` or `.directoryName`. | |
::: important | |
Glob patterns always match files and directories that begin with a dot, such as `.foo.js` or `.fixtures`, unless those files are explicitly ignored. The only dot directory ignored by default is `.git`. | |
::: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! Leaving open for @nzakas to verify.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
added the information that flat config doesn't ignore files or directories with name starts from dot.
some issue had been opened that mentions this #18214 and #18236
Is there anything you'd like reviewers to focus on?