New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add npm script to run WebdriverIO test #18238
Conversation
✅ Deploy Preview for docs-eslint canceled.
|
it was disabled as encountered the error: Is there any way we can verify that it has been fixed? |
Hm, good point. I don't know how this can be verified. But if it's not necessary to run the browser tests in Jenkins maybe we could add a switch to the task in Makefile.js, so the browser test will run locally with |
I think it's fine not to run the browser test on Jenkins, as we'll always have CI checks right before the release (when I also think it's fine to keep the browser test excluded from |
Yeah, we disabled these on Jenkins because there always seemed to be some configuration issue and we already knew that GitHub CI passed with it running. I also agree with @mdjermanovic that we don't need to add it to |
Thanks! I've re-excluded the browser test from the general test task and added an npm script to run it manually. |
package.json
Outdated
@@ -32,7 +32,8 @@ | |||
"test": "node Makefile.js test", | |||
"test:cli": "mocha", | |||
"test:fuzz": "node Makefile.js fuzz", | |||
"test:performance": "node Makefile.js perf" | |||
"test:performance": "node Makefile.js perf", | |||
"test:wdio": "node Makefile.js wdio" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wido is just the used tool, and the gha job name is test-on-broswer
. :)
"test:wdio": "node Makefile.js wdio" | |
"test:browser": "node Makefile.js wdio" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 9b57f7e, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[X] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Re-enabled WebdriverIO tests.Added npm scripttest:wdio
to run the WebdriverIO test locally.Is there anything you'd like reviewers to focus on?
WebdriverIO has been running smoothly in CI for the last couple of months. Shall we try to re-enable it for tests in Jenkins? Or maybe just for local tests?