feat: use-isnan report NaN in indexOf and lastIndexOf with fromIndex
#18225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-eslint canceled.
|
mdjermanovic
added
the
accepted
mdjermanovic
requested changes
Mar 23, 2024
tests/lib/rules/use-isnan.js
Outdated
| * code: "foo.lastIndexOf(NaN, b)", | ||
| * options: [{ enforceForIndexOf: true }] | ||
| * }, | ||
| */ |
There was a problem hiding this comment.
Can you uncomment these tests and add 3rd argument that would make them valid?
There was a problem hiding this comment.
@mdjermanovic, in this rule following code
myArray.indexOf(NaN)fixes to
myArray.findIndex(Number.isNaN)but both cases return -1 so is this fix correct or there is something i am not aware of?
There was a problem hiding this comment.
The fix is correct. For example:
const myArray = [0, 1, 2, NaN, 4, 5];
console.log(myArray.indexOf(NaN)); // -1
console.log(myArray.findIndex(Number.isNaN)); // 3There was a problem hiding this comment.
Got it, thanks!
mdjermanovic
changed the title
indexOf and lastIndexOf with fromIndexindexOf and lastIndexOf with fromIndex
mdjermanovic
changed the title
indexOf and lastIndexOf with fromIndexindexOf and lastIndexOf with fromIndex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
made the rule
use-isnanto report NaN inindexOfandlastIndexOfwith fromIndexnow rule will report following code-
Is there anything you'd like reviewers to focus on?
Fixes: #18161