New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update get-started to the new @eslint/create-config
#18217
Conversation
✅ Deploy Preview for docs-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
README.md
Outdated
{ | ||
"rules": { | ||
"semi": ["error", "always"], | ||
"quotes": ["error", "double"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wondering if we can (at some time) revisit the docs to replace formatting rules with some others. (formatting rules have been deprecated).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eslint/config
will no longer have an option to configure semi
, quotes
, and other formatting rules?
Perhaps a config like this would be a more representative example:
import pluginJs from "@eslint/js";
export default [
pluginJs.configs.recommended,
];
Hi everyone, it looks like we lost track of this pull request. Please review and see what the next steps are. This pull request will auto-close in 7 days without an update. |
Not stale, this change depends on eslint/create-config#81 which isn't merged yet. |
docs/src/use/getting-started.md
Outdated
|
||
# or (`eslint-config` prefix is optional) | ||
npm init @eslint/config -- --config eslint-config-semistandard | ||
npm init @eslint/config -- --config eslint-config-standard | ||
|
||
# ⚠️ npm 6.x no extra double-dash: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to eslint/create-config#81, can we also remove npm 6.x specifics from this document?
eslint/create-config#81 has been merged. What do we need to update? |
friendly ping @aladdin-add, today is the final v9.0.0 release :) |
164a34c
to
230c0bb
Compare
It's ready for review now. @mdjermanovic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Update the get-started of the documentation with the upcoming
@eslint/create-config
.Is there anything you'd like reviewers to focus on?
it can be merged after eslint/create-config#81 merged and released.