Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix incorrect example in no-lone-blocks #18215

Merged
merged 1 commit into from Mar 17, 2024

Conversation

Tanujkanti4441
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

set the sourceType to script because function declarations are valid in module or strict mode in no-lone-blocks rule.

Screenshot 2024-03-17 212524

Is there anything you'd like reviewers to focus on?

@Tanujkanti4441 Tanujkanti4441 requested a review from a team as a code owner March 17, 2024 15:57
@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label Mar 17, 2024
Copy link

netlify bot commented Mar 17, 2024

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 31db263
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/65f712ff650d120008c94c44
😎 Deploy Preview https://deploy-preview-18215--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdjermanovic mdjermanovic added the accepted There is consensus among the team that this change meets the criteria for inclusion label Mar 17, 2024
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit 4769c86 into eslint:main Mar 17, 2024
19 checks passed
@Tanujkanti4441 Tanujkanti4441 deleted the docs-fix branch March 17, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion documentation Relates to ESLint's documentation
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

None yet

2 participants