feat: Add loadESLint() API method for v8 #18098

nzakas · 2024-02-09T00:26:54Z

Note: Intentionally sent to v8.x branch.

Prerequisites checklist

I have read the contributing guidelines.

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[x] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Added the loadESLint() method to the public API.
Updated the shouldUseFlatConfig() function accept an optional cwd argument.
Added configType to both ESLint and FlatESLint.
Added tests for all of the above.
Added docs to the Node.js API document.

refs #18075

Is there anything you'd like reviewers to focus on?

refs #18075

netlify · 2024-02-09T00:26:59Z

✅ Deploy Preview for docs-eslint canceled.

Name	Link
🔨 Latest commit	`96dedf2`
🔍 Latest deploy log	https://app.netlify.com/sites/docs-eslint/deploys/65cbaa32153a0e00071ead38

tests/lib/api.js

snitin315

LGTM, thanks! I'll leave it open for others to review.

tests/lib/api.js

Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>

tests/lib/api.js

Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>

mdjermanovic

LGTM, thanks!

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [eslint](https://eslint.org) ([source](https://github.com/eslint/eslint)) | devDependencies | minor | [`8.56.0` -> `8.57.0`](https://renovatebot.com/diffs/npm/eslint/8.56.0/8.57.0) | | [@types/eslint](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/eslint) ([source](https://github.com/DefinitelyTyped/DefinitelyTyped)) | devDependencies | patch | [`8.56.2` -> `8.56.6`](https://renovatebot.com/diffs/npm/@types%2feslint/8.56.2/8.56.6) | --- ### Release Notes <details> <summary>eslint/eslint (eslint)</summary> ### [`v8.57.0`](https://github.com/eslint/eslint/releases/tag/v8.57.0) [Compare Source](eslint/eslint@v8.56.0...v8.57.0) #### Features - [`1120b9b`](eslint/eslint@1120b9b) feat: Add loadESLint() API method for v8 ([#18098](eslint/eslint#18098)) (Nicholas C. Zakas) - [`dca7d0f`](eslint/eslint@dca7d0f) feat: Enable `eslint.config.mjs` and `eslint.config.cjs` ([#18066](eslint/eslint#18066)) (Nitin Kumar) #### Bug Fixes - [`2196d97`](eslint/eslint@2196d97) fix: handle absolute file paths in `FlatRuleTester` ([#18064](eslint/eslint#18064)) (Nitin Kumar) - [`69dd1d1`](eslint/eslint@69dd1d1) fix: Ensure config keys are printed for config errors ([#18067](eslint/eslint#18067)) (Nitin Kumar) - [`9852a31`](eslint/eslint@9852a31) fix: deep merge behavior in flat config ([#18065](eslint/eslint#18065)) (Nitin Kumar) - [`4c7e9b0`](eslint/eslint@4c7e9b0) fix: allow circular references in config ([#18056](eslint/eslint#18056)) (Milos Djermanovic) #### Documentation - [`84922d0`](eslint/eslint@84922d0) docs: Show prerelease version in dropdown ([#18139](eslint/eslint#18139)) (Nicholas C. Zakas) - [`5b8c363`](eslint/eslint@5b8c363) docs: Switch to Ethical Ads ([#18117](eslint/eslint#18117)) (Milos Djermanovic) - [`77dbfd9`](eslint/eslint@77dbfd9) docs: show NEXT in version selectors ([#18052](eslint/eslint#18052)) (Milos Djermanovic) #### Chores - [`1813aec`](eslint/eslint@1813aec) chore: upgrade [@eslint/js](https://github.com/eslint/js)[@8](https://github.com/8).57.0 ([#18143](eslint/eslint#18143)) (Milos Djermanovic) - [`5c356bb`](eslint/eslint@5c356bb) chore: package.json update for [@eslint/js](https://github.com/eslint/js) release (Jenkins) - [`f4a1fe2`](eslint/eslint@f4a1fe2) test: add more tests for ignoring files and directories ([#18068](eslint/eslint#18068)) (Nitin Kumar) - [`42c0aef`](eslint/eslint@42c0aef) ci: Enable CI for `v8.x` branch ([#18047](eslint/eslint#18047)) (Milos Djermanovic) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://gitea.vylpes.xyz/RabbitLabs/Droplet/pulls/295 Co-authored-by: Renovate Bot <renovate@vylpes.com> Co-committed-by: Renovate Bot <renovate@vylpes.com>

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [eslint](https://eslint.org) ([source](https://github.com/eslint/eslint)) | devDependencies | minor | [`8.56.0` -> `8.57.0`](https://renovatebot.com/diffs/npm/eslint/8.56.0/8.57.0) | --- ### Release Notes <details> <summary>eslint/eslint (eslint)</summary> ### [`v8.57.0`](https://github.com/eslint/eslint/releases/tag/v8.57.0) [Compare Source](eslint/eslint@v8.56.0...v8.57.0) #### Features - [`1120b9b`](eslint/eslint@1120b9b) feat: Add loadESLint() API method for v8 ([#18098](eslint/eslint#18098)) (Nicholas C. Zakas) - [`dca7d0f`](eslint/eslint@dca7d0f) feat: Enable `eslint.config.mjs` and `eslint.config.cjs` ([#18066](eslint/eslint#18066)) (Nitin Kumar) #### Bug Fixes - [`2196d97`](eslint/eslint@2196d97) fix: handle absolute file paths in `FlatRuleTester` ([#18064](eslint/eslint#18064)) (Nitin Kumar) - [`69dd1d1`](eslint/eslint@69dd1d1) fix: Ensure config keys are printed for config errors ([#18067](eslint/eslint#18067)) (Nitin Kumar) - [`9852a31`](eslint/eslint@9852a31) fix: deep merge behavior in flat config ([#18065](eslint/eslint#18065)) (Nitin Kumar) - [`4c7e9b0`](eslint/eslint@4c7e9b0) fix: allow circular references in config ([#18056](eslint/eslint#18056)) (Milos Djermanovic) #### Documentation - [`84922d0`](eslint/eslint@84922d0) docs: Show prerelease version in dropdown ([#18139](eslint/eslint#18139)) (Nicholas C. Zakas) - [`5b8c363`](eslint/eslint@5b8c363) docs: Switch to Ethical Ads ([#18117](eslint/eslint#18117)) (Milos Djermanovic) - [`77dbfd9`](eslint/eslint@77dbfd9) docs: show NEXT in version selectors ([#18052](eslint/eslint#18052)) (Milos Djermanovic) #### Chores - [`1813aec`](eslint/eslint@1813aec) chore: upgrade [@eslint/js](https://github.com/eslint/js)[@8](https://github.com/8).57.0 ([#18143](eslint/eslint#18143)) (Milos Djermanovic) - [`5c356bb`](eslint/eslint@5c356bb) chore: package.json update for [@eslint/js](https://github.com/eslint/js) release (Jenkins) - [`f4a1fe2`](eslint/eslint@f4a1fe2) test: add more tests for ignoring files and directories ([#18068](eslint/eslint#18068)) (Nitin Kumar) - [`42c0aef`](eslint/eslint@42c0aef) ci: Enable CI for `v8.x` branch ([#18047](eslint/eslint#18047)) (Milos Djermanovic) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://gitea.vylpes.xyz/External/card-drop/pulls/186 Co-authored-by: Renovate Bot <renovate@vylpes.com> Co-committed-by: Renovate Bot <renovate@vylpes.com>

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [eslint](https://eslint.org) ([source](https://github.com/eslint/eslint)) | devDependencies | minor | [`8.56.0` -> `8.57.0`](https://renovatebot.com/diffs/npm/eslint/8.56.0/8.57.0) | | [@types/eslint](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/eslint) ([source](https://github.com/DefinitelyTyped/DefinitelyTyped)) | devDependencies | patch | [`8.56.2` -> `8.56.3`](https://renovatebot.com/diffs/npm/@types%2feslint/8.56.2/8.56.3) | --- ### Release Notes <details> <summary>eslint/eslint (eslint)</summary> ### [`v8.57.0`](https://github.com/eslint/eslint/releases/tag/v8.57.0) [Compare Source](eslint/eslint@v8.56.0...v8.57.0) #### Features - [`1120b9b`](eslint/eslint@1120b9b) feat: Add loadESLint() API method for v8 ([#18098](eslint/eslint#18098)) (Nicholas C. Zakas) - [`dca7d0f`](eslint/eslint@dca7d0f) feat: Enable `eslint.config.mjs` and `eslint.config.cjs` ([#18066](eslint/eslint#18066)) (Nitin Kumar) #### Bug Fixes - [`2196d97`](eslint/eslint@2196d97) fix: handle absolute file paths in `FlatRuleTester` ([#18064](eslint/eslint#18064)) (Nitin Kumar) - [`69dd1d1`](eslint/eslint@69dd1d1) fix: Ensure config keys are printed for config errors ([#18067](eslint/eslint#18067)) (Nitin Kumar) - [`9852a31`](eslint/eslint@9852a31) fix: deep merge behavior in flat config ([#18065](eslint/eslint#18065)) (Nitin Kumar) - [`4c7e9b0`](eslint/eslint@4c7e9b0) fix: allow circular references in config ([#18056](eslint/eslint#18056)) (Milos Djermanovic) #### Documentation - [`84922d0`](eslint/eslint@84922d0) docs: Show prerelease version in dropdown ([#18139](eslint/eslint#18139)) (Nicholas C. Zakas) - [`5b8c363`](eslint/eslint@5b8c363) docs: Switch to Ethical Ads ([#18117](eslint/eslint#18117)) (Milos Djermanovic) - [`77dbfd9`](eslint/eslint@77dbfd9) docs: show NEXT in version selectors ([#18052](eslint/eslint#18052)) (Milos Djermanovic) #### Chores - [`1813aec`](eslint/eslint@1813aec) chore: upgrade [@eslint/js](https://github.com/eslint/js)[@8](https://github.com/8).57.0 ([#18143](eslint/eslint#18143)) (Milos Djermanovic) - [`5c356bb`](eslint/eslint@5c356bb) chore: package.json update for [@eslint/js](https://github.com/eslint/js) release (Jenkins) - [`f4a1fe2`](eslint/eslint@f4a1fe2) test: add more tests for ignoring files and directories ([#18068](eslint/eslint#18068)) (Nitin Kumar) - [`42c0aef`](eslint/eslint@42c0aef) ci: Enable CI for `v8.x` branch ([#18047](eslint/eslint#18047)) (Milos Djermanovic) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://gitea.vylpes.xyz/RabbitLabs/random-bunny/pulls/150 Reviewed-by: Vylpes <ethan@vylpes.com> Co-authored-by: Renovate Bot <renovate@vylpes.com> Co-committed-by: Renovate Bot <renovate@vylpes.com>

feat: Add loadESLint() API method for v8

78beb56

refs #18075

nzakas requested a review from a team as a code owner February 9, 2024 00:26

eslint-github-bot bot added the feature This change adds a new feature to ESLint label Feb 9, 2024

Update docs

2d8e8ad

snitin315 reviewed Feb 9, 2024

View reviewed changes

tests/lib/api.js Show resolved Hide resolved

Add tests for loadESLint() to return ESLint

bc94c2f

snitin315 added the accepted There is consensus among the team that this change meets the criteria for inclusion label Feb 9, 2024

snitin315 approved these changes Feb 9, 2024

View reviewed changes

nzakas added 2 commits February 9, 2024 13:36

Move static property out of constructor for older Node.js versions

92aa857

Add more tests

27c88e0

mdjermanovic mentioned this pull request Feb 9, 2024

Request: backporting flat config bug fixes to v8 #17966

Closed

mdjermanovic reviewed Feb 12, 2024

View reviewed changes

tests/lib/api.js Outdated Show resolved Hide resolved

Update tests/lib/api.js

71ef76f

Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>

mdjermanovic reviewed Feb 13, 2024

View reviewed changes

tests/lib/api.js Outdated Show resolved Hide resolved

Update tests/lib/api.js

96dedf2

Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>

mdjermanovic approved these changes Feb 14, 2024

View reviewed changes

mdjermanovic merged commit 1120b9b into v8.x Feb 14, 2024
20 checks passed

mdjermanovic deleted the load-eslint-v8x branch February 14, 2024 08:49

danilvilh66 mentioned this pull request Mar 16, 2024

[Snyk] Upgrade @eslint/js from 8.56.0 to 8.57.0 danilvilh66/eslint#1

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add loadESLint() API method for v8 #18098

feat: Add loadESLint() API method for v8 #18098

nzakas commented Feb 9, 2024

netlify bot commented Feb 9, 2024 •

edited

snitin315 left a comment

mdjermanovic left a comment

feat: Add loadESLint() API method for v8 #18098

feat: Add loadESLint() API method for v8 #18098

Conversation

nzakas commented Feb 9, 2024

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

netlify bot commented Feb 9, 2024 • edited

✅ Deploy Preview for docs-eslint canceled.

snitin315 left a comment

Choose a reason for hiding this comment

mdjermanovic left a comment

Choose a reason for hiding this comment

netlify bot commented Feb 9, 2024 •

edited