Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add stricter rule test validations to v9 migration guide #18085

Merged
merged 1 commit into from Feb 5, 2024

Conversation

mdjermanovic
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

Adds changes from #17654 to the v9 migration guide.

What changes did you make? (Give an overview)

Updated v9 migration guide.

Is there anything you'd like reviewers to focus on?

@mdjermanovic mdjermanovic added documentation Relates to ESLint's documentation accepted There is consensus among the team that this change meets the criteria for inclusion labels Feb 5, 2024
@mdjermanovic mdjermanovic requested a review from a team as a code owner February 5, 2024 11:58
Copy link

netlify bot commented Feb 5, 2024

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 06638ce
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/65c0cd669450e60008a22807
😎 Deploy Preview https://deploy-preview-18085--docs-eslint.netlify.app/use/migrate-to-9.0.0
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@amareshsm amareshsm merged commit 6ea339e into main Feb 5, 2024
18 checks passed
@amareshsm amareshsm deleted the migration-stricter-ruletester branch February 5, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion documentation Relates to ESLint's documentation
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

None yet

4 participants