Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: use relative link from CLI to core concepts #18083

Merged
merged 1 commit into from Feb 5, 2024

Conversation

mdjermanovic
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

Fixes one recently added link between documents to be relative, as we have multiple docs sites.

What changes did you make? (Give an overview)

Updated the link.

Is there anything you'd like reviewers to focus on?

@mdjermanovic mdjermanovic requested a review from a team as a code owner February 4, 2024 19:17
Copy link

netlify bot commented Feb 4, 2024

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 5fcf64e
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/65bfe2e25838ab00082eb251
😎 Deploy Preview https://deploy-preview-18083--docs-eslint.netlify.app/use/command-line-interface
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label Feb 4, 2024
@amareshsm amareshsm added the accepted There is consensus among the team that this change meets the criteria for inclusion label Feb 4, 2024
Copy link
Sponsor Member

@bmish bmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks.

I see some other eslint.org links in the docs. Seems like we need a CI check for this. I don't see any markdownlint rules that would help.

@aladdin-add aladdin-add merged commit 3c816f1 into main Feb 5, 2024
18 checks passed
@aladdin-add aladdin-add deleted the docs-fix-relative branch February 5, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion documentation Relates to ESLint's documentation
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

None yet

4 participants