-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Request: Drop Node v12/v14/v16/v17/v19 support #17595
Comments
Most recent versions at the moment: v18.18.0 and v20.7.0. |
This comment was marked as off-topic.
This comment was marked as off-topic.
@mdjermanovic Are there any features in semver minor of 18.x that ESLint could benefit from? |
@kibertoad that's what we need to find out. Would you be interested in researching what has been added in the various semver minor releases and commenting back here? |
I'd be happy to |
I think with Node v18 we can remove |
@kibertoad do you still intend to do this? |
@nzakas yes. please give me time until Monday (eod) |
@kibertoad sounds good. Thanks! |
One day late, but I've finally started the research today. |
|
@kibertoad awesome, thank you! Since we opened this, v20 has gone LTS, so I'd suggest we set our minimum v18 version at v18.18.0. For v20, I'd suggest we set our minimum to be v20.7.0, unless anything super useful has been released since then. |
@nzakas Sounds good!
Not really, 20.8.0 improves performance of streams and improves memory management of |
probably best to start with v20.9.0 then, since there’s no long term support for any v20 releases before then |
Sounds good to me. In the meantime, Node.js 21 has been released. The latest version is v21.1.0, so perhaps we could set the requirements to:
Thoughts? |
Works for me. |
(again, tho, i'd start with 20.9.0 and not 20.7.0 since 20.9 is LTS and 20.7 is not) |
Drops support for Node.js 12/14/16/17/19 Fixes #17595
I'm fine with that. @mdjermanovic ? |
Makes sense to me. I updated #17725 with |
Per 2023-11-30 tsc-meeting decision, this issue has been set to |
* feat!: Require Node.js `^18.18.0 || ^20.7.0 || >=21.1.0` Drops support for Node.js 12/14/16/17/19 Fixes #17595 * update getting-started * fix lint errors * 20.7.0 -> 20.9.0
refs: eslint/eslint#17595 Signed-off-by: 唯然 <weiran.zsd@outlook.com>
refs: eslint/eslint#17595 Signed-off-by: 唯然 <weiran.zsd@outlook.com>
refs: eslint/eslint#17595 Signed-off-by: 唯然 <weiran.zsd@outlook.com>
refs: eslint/eslint#17595 Signed-off-by: 唯然 <weiran.zsd@outlook.com>
* feat!: Require Node.js ^18.18.0 || ^20.9.0 || >=21.1.0 refs: eslint/eslint#17595 Signed-off-by: 唯然 <weiran.zsd@outlook.com> * Update ci.yml --------- Signed-off-by: 唯然 <weiran.zsd@outlook.com>
refs: eslint/eslint#17595 Signed-off-by: 唯然 <weiran.zsd@outlook.com>
* feat!: Require Node.js ^18.18.0 || ^20.9.0 || >=21.1.0 refs: eslint/eslint#17595 * Update ci.yml * chore: rm patch-esmock * docs: update node.js requirement
refs: eslint/eslint#17595 Signed-off-by: 唯然 <weiran.zsd@outlook.com>
* feat!: Require Node.js ^18.18.0 || ^20.9.0 || >=21.1.0 refs: eslint/eslint#17595 Signed-off-by: 唯然 <weiran.zsd@outlook.com> * Update ci.yml --------- Signed-off-by: 唯然 <weiran.zsd@outlook.com>
ESLint version
8.49.0
What problem do you want to solve?
ESLint v8 supports
"node": "^12.22.0 || ^14.17.0 || >=16.0.0"
.Node 12, 14, 16, 17, 19 are EOL.
What do you think is the correct solution?
In v9, we'd drop support for EOL versions and keep only Node 18, Node 20, and above.
Participation
Additional comments
At the moment, I don't have a concrete proposal for minor versions of Node 18 and Node 20 we'd like to support. Any suggestions?
The text was updated successfully, but these errors were encountered: