feat!: remove formatters except html, json(-with-metadata), and stylish #17531

JoshuaKGoldberg · 2023-09-05T04:54:32Z

Prerequisites checklist

I have read the contributing guidelines.

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain: Removes something from core (formatters)

What changes did you make? (Give an overview)

Removes all but the html, json, json-with-metadata, and stylish formatters.

Is there anything you'd like reviewers to focus on?

This is breaking and will have to wait for the next major version. But I was excited about the work and figured I'd send it in early. 🙂

Fixes #17524.

netlify · 2023-09-05T04:54:37Z

✅ Deploy Preview for docs-eslint canceled.

Name	Link
🔨 Latest commit	`61532a4`
🔍 Latest deploy log	https://app.netlify.com/sites/docs-eslint/deploys/656b39ba70f90e0008216528

Makefile.js

nzakas · 2023-09-05T15:04:19Z

No worries, we'll switch this to a draft. Please be sure to mention the original issue in the PR so it will be closed when this is merged.

github-actions · 2023-09-15T22:31:22Z

Hi everyone, it looks like we lost track of this pull request. Please review and see what the next steps are. This pull request will auto-close in 7 days without an update.

eslint-github-bot · 2023-09-26T12:48:14Z

Hi @JoshuaKGoldberg!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.

The length of the commit message must be less than or equal to 72

To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint here

eslint-github-bot · 2023-09-26T12:49:30Z

Hi @JoshuaKGoldberg!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.

The length of the commit message must be less than or equal to 72

To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint here

eslint-github-bot · 2023-09-26T12:53:27Z

Hi @JoshuaKGoldberg!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.

The length of the commit message must be less than or equal to 72

To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint here

github-actions · 2023-10-06T22:31:21Z

Hi everyone, it looks like we lost track of this pull request. Please review and see what the next steps are. This pull request will auto-close in 7 days without an update.

github-actions · 2023-10-17T22:31:20Z

Hi everyone, it looks like we lost track of this pull request. Please review and see what the next steps are. This pull request will auto-close in 7 days without an update.

github-actions · 2023-10-28T22:31:18Z

Hi everyone, it looks like we lost track of this pull request. Please review and see what the next steps are. This pull request will auto-close in 7 days without an update.

Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>

mdjermanovic · 2023-11-06T12:21:14Z

Can you also update this Set (this is for flat config mode):

eslint/lib/eslint/flat-eslint.js

Line 96 in 5454c22

const removedFormatters = new Set(["table", "codeframe"]);

nzakas

LGTM pending @mdjermanovic's suggestions.

mdjermanovic · 2023-11-06T18:23:17Z

@JoshuaKGoldberg we're keeping breaking changes as drafts for now so that we don't accidentally merge some before we start with v9 prereleases.

github-actions · 2023-11-16T22:31:33Z

Hi everyone, it looks like we lost track of this pull request. Please review and see what the next steps are. This pull request will auto-close in 7 days without an update.

github-actions · 2023-11-27T22:31:27Z

Hi everyone, it looks like we lost track of this pull request. Please review and see what the next steps are. This pull request will auto-close in 7 days without an update.

nzakas · 2023-11-30T21:20:04Z

@JoshuaKGoldberg there are some requests for updates on this PR, can you take a look?

lib/cli-engine/formatters/removed.js

mdjermanovic

LGTM, thanks!

* main: (25 commits) test: ensure that CLI tests run with FlatESLint (eslint#17884) fix!: Behavior of CLI when no arguments are passed (eslint#17644) docs: Update README Revert "feat!: Remove CodePath#currentSegments" (eslint#17890) feat!: Update shouldUseFlatConfig and CLI so flat config is default (eslint#17748) feat!: Remove CodePath#currentSegments (eslint#17756) chore: update dependency markdownlint-cli to ^0.38.0 (eslint#17865) feat!: deprecate no-new-symbol, recommend no-new-native-nonconstructor (eslint#17710) feat!: check for parsing errors in suggestion fixes (eslint#16639) feat!: assert suggestion messages are unique in rule testers (eslint#17532) feat!: `no-invalid-regexp` make allowConstructorFlags case-sensitive (eslint#17533) fix!: no-sequences rule schema correction (eslint#17878) feat!: Update `eslint:recommended` configuration (eslint#17716) feat!: drop support for string configurations in flat config array (eslint#17717) feat!: Remove `SourceCode#getComments()` (eslint#17715) feat!: Remove deprecated context methods (eslint#17698) feat!: Swap FlatESLint-ESLint, FlatRuleTester-RuleTester in API (eslint#17823) feat!: remove formatters except html, json(-with-metadata), and stylish (eslint#17531) feat!: Require Node.js `^18.18.0 || ^20.9.0 || >=21.1.0` (eslint#17725) fix: allow circular references in config (eslint#17752) ...

feat!: remove formatters other than json(-with-metadata) and stylish

38b9391

eslint-github-bot bot added breaking This change is backwards-incompatible feature This change adds a new feature to ESLint labels Sep 5, 2023

JoshuaKGoldberg commented Sep 5, 2023

View reviewed changes

Makefile.js Outdated Show resolved Hide resolved

JoshuaKGoldberg marked this pull request as ready for review September 5, 2023 05:17

JoshuaKGoldberg requested a review from a team as a code owner September 5, 2023 05:17

nzakas marked this pull request as draft September 5, 2023 15:03

JoshuaKGoldberg mentioned this pull request Sep 5, 2023

Change Request: Remove all formatters except stylish, html, json, and json-with-meta #17524

Closed

1 task

github-actions bot added the Stale label Sep 15, 2023

Rec0iL99 removed the Stale label Sep 15, 2023

JoshuaKGoldberg changed the title ~~feat!: remove formatters other than json(-with-metadata) and stylish~~ feat!: remove formatters other than html, json(-with-metadata), and stylish Sep 26, 2023

Merge branch 'main' into remove-formatters

a0172ac

Add back html

ba1a12f

JoshuaKGoldberg changed the title ~~feat!: remove formatters other than html, json(-with-metadata), and stylish~~ feat!: remove formatters except html, json(-with-metadata), and stylish Sep 26, 2023

github-actions bot added the Stale label Oct 6, 2023

Rec0iL99 removed the Stale label Oct 7, 2023

github-actions bot added the Stale label Oct 17, 2023

nzakas removed the Stale label Oct 18, 2023

github-actions bot added the Stale label Oct 28, 2023

JoshuaKGoldberg mentioned this pull request Nov 1, 2023

Rename and/or merging of features into ESLint core? shuoshubao/eslint-formatter-html#6

Open

mdjermanovic removed the Stale label Nov 4, 2023

JoshuaKGoldberg and others added 4 commits November 5, 2023 13:30

Merge branch 'main' into remove-formatters

074a55c

Merge branch 'main'

5f7b0a7

Reset formatters-meta order, and add removedFormatters Set

88f05d2

Apply suggestions from code review

e52516b

Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>

JoshuaKGoldberg marked this pull request as ready for review November 5, 2023 18:50

nzakas approved these changes Nov 6, 2023

View reviewed changes

mdjermanovic marked this pull request as draft November 6, 2023 18:23

github-actions bot added the Stale label Nov 16, 2023

Rec0iL99 removed the Stale label Nov 17, 2023

github-actions bot added the Stale label Nov 27, 2023

Rec0iL99 assigned JoshuaKGoldberg Nov 27, 2023

Rec0iL99 removed the Stale label Nov 27, 2023

JoshuaKGoldberg added 3 commits December 1, 2023 16:44

Consolidated removed formatters set

05e992e

chore: undo formatters/index.md changes

32fc5c0

Merge branch 'main' into remove-formatters

cbf7860

mdjermanovic requested changes Dec 2, 2023

View reviewed changes

lib/cli-engine/formatters/removed.js Outdated Show resolved Hide resolved

Moved back to per-file sets

61532a4

JoshuaKGoldberg requested a review from mdjermanovic December 2, 2023 14:19

mdjermanovic approved these changes Dec 2, 2023

View reviewed changes

mdjermanovic marked this pull request as ready for review December 20, 2023 13:11

mdjermanovic merged commit 5304da0 into eslint:main Dec 20, 2023
22 checks passed

JoshuaKGoldberg deleted the remove-formatters branch December 20, 2023 16:02

JoshuaKGoldberg mentioned this pull request Mar 21, 2024

docs: add Glossary page #18187

Merged

1 task

rwlxxvii mentioned this pull request May 17, 2024

[Snyk] Upgrade eslint from 9.0.0 to 9.1.1 rwlxxvii/containers#114

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat!: remove formatters except html, json(-with-metadata), and stylish #17531

feat!: remove formatters except html, json(-with-metadata), and stylish #17531

JoshuaKGoldberg commented Sep 5, 2023 •

edited

netlify bot commented Sep 5, 2023 •

edited

nzakas commented Sep 5, 2023

github-actions bot commented Sep 15, 2023

eslint-github-bot bot commented Sep 26, 2023

eslint-github-bot bot commented Sep 26, 2023

eslint-github-bot bot commented Sep 26, 2023

github-actions bot commented Oct 6, 2023

github-actions bot commented Oct 17, 2023

github-actions bot commented Oct 28, 2023

mdjermanovic commented Nov 6, 2023

nzakas left a comment

mdjermanovic commented Nov 6, 2023

github-actions bot commented Nov 16, 2023

github-actions bot commented Nov 27, 2023

nzakas commented Nov 30, 2023

mdjermanovic left a comment

feat!: remove formatters except html, json(-with-metadata), and stylish #17531

feat!: remove formatters except html, json(-with-metadata), and stylish #17531

Conversation

JoshuaKGoldberg commented Sep 5, 2023 • edited

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

netlify bot commented Sep 5, 2023 • edited

✅ Deploy Preview for docs-eslint canceled.

nzakas commented Sep 5, 2023

github-actions bot commented Sep 15, 2023

eslint-github-bot bot commented Sep 26, 2023

eslint-github-bot bot commented Sep 26, 2023

eslint-github-bot bot commented Sep 26, 2023

github-actions bot commented Oct 6, 2023

github-actions bot commented Oct 17, 2023

github-actions bot commented Oct 28, 2023

mdjermanovic commented Nov 6, 2023

nzakas left a comment

Choose a reason for hiding this comment

mdjermanovic commented Nov 6, 2023

github-actions bot commented Nov 16, 2023

github-actions bot commented Nov 27, 2023

nzakas commented Nov 30, 2023

mdjermanovic left a comment

Choose a reason for hiding this comment

JoshuaKGoldberg commented Sep 5, 2023 •

edited

netlify bot commented Sep 5, 2023 •

edited