New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: change default ignore pattern to **/node_modules/
in flat config
#17184
Conversation
✅ Deploy Preview for docs-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Thanks for this PR! I would recommend to also update this message, as it could be slightly misleading: eslint/lib/eslint/eslint-helpers.js Line 601 in 0c415cd
We could also simply point users to the documentation instead of suggesting to add CLI options (because IINM there is no guarantee that the CLI is being used here?). |
Good catch! Updated in 3fa6c92.
Since we can't know at this point how is eslint being used and whether the pattern should be added in a config file or CLI command or perhaps in a configuration for a third-party tool, I changed "ignore-pattern" to generic "ignore pattern". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Rebased to fix merge conflicts. |
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[x] Add something to the core
[ ] Other, please explain:
Fixes #17113
What changes did you make? (Give an overview)
Changed the default ignore pattern to
**/node_modules/
, updated tests, and added an example of how to unignore a directory in node_modules.Is there anything you'd like reviewers to focus on?