Add quote-props rule

[mathiasbynens]

I like to ensure property names in object literals are always wrapped in quotes, since depending on the property name sometimes you need to quote them anyway.

I’ve always wanted this in JS{L,H}int. It was surprisingly easy to add this rule to ESLint :)

[mathiasbynens]

The next step would be to specify the quote type (single or double quotes) and have ESLint check that, too.

[mathiasbynens]

Thanks for the feedback. I’ve applied the changes and force-pushed my amended commit.

[nzakas]

Merged in, thanks!

Would you mind adding some documentation to the wiki? There are some examples here:
https://github.com/nzakas/eslint/wiki/Rules

I think this would fall under "stylistic issues"?

[mathiasbynens]

Done: https://github.com/nzakas/eslint/wiki/Quote-props

I would argue this is not just a stylistic issue — as explained in the docs, consistently quoting property names helps avoids lots of issues. But I’m fine with that categorization.

Suggestion: keep the documentation in a docs folder in the repository rather than using a separate Wiki with its own version control history, so that the master branch and the docs are always up to date, and so that people can submit pull requests for documentation.

[nzakas]

I have a hard time buying that it's not a stylistic issue - but we can agree to disagree because it doesn't matter in this context. :)

For docs, I understand your reasoning. My main problem with that approach is that it becomes less a navigable site and more digging into the code base to get information. I don't want people to have to go into the code repo to get information. I'm certainly open to suggestions in this regard (though perhaps a new issue would be better than overloading this one).

[evangoer]

I agree with Mathias, pull requests for documentation are a good thing. Keep the docs in a docs/ folder, and register yourself a shiny .io domain for hosting them.

[nzakas]

I'm not opposed to it, do you want to volunteer to take that effort on? :)

On Sat, Jul 13, 2013 at 6:59 PM, Evan Goer notifications@github.com wrote:

I agree with Mathias, pull requests for documentation are a good thing.
Keep the docs in a docs/ folder, and register yourself a shiny .io domain
for hosting them.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/17#issuecomment-20930294
.

---

Nicholas C. Zakas
@SlickNet

Author, Professional JavaScript for Web Developers
Buy it at Amazon.com:
http://www.amazon.com/Professional-JavaScript-Developers-Nicholas-Zakas/dp/1118026691/ref=sr_1_3

[evangoer]

Hmmm. Is there a frosty beverage in it for me? :)

[nzakas]

Absolutely. Yes.

On Sun, Jul 14, 2013 at 12:17 PM, Evan Goer notifications@github.comwrote:

Hmmm. Is there a frosty beverage in it for me? :)

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/17#issuecomment-20941842
.

---

Nicholas C. Zakas
@SlickNet

Author, Professional JavaScript for Web Developers
Buy it at Amazon.com:
http://www.amazon.com/Professional-JavaScript-Developers-Nicholas-Zakas/dp/1118026691/ref=sr_1_3