New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Copy edits on Maintain ESLint docs #16939

Merged

mdjermanovic merged 8 commits into eslint:main from bpmutter:maintain_eslint_copy_edits

Mar 13, 2023

Contributor

bpmutter commented Feb 26, 2023

Prerequisites checklist

I have read the contributing guidelines.

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Copy edits throughout Maintain ESLint docs

Is there anything you'd like reviewers to focus on?

Resolves #16938


          docs: Copy edits on Maintain ESLint docs

6680bde

bpmutter requested a review from a team as a code owner

February 26, 2023 19:54

eslint-github-bot bot added triage documentation labels

netlify bot commented Feb 26, 2023 •

edited

✅ Deploy Preview for docs-eslint ready!

Name	Link
🔨 Latest commit	`da6523b`
🔍 Latest deploy log	https://app.netlify.com/sites/docs-eslint/deploys/640cdee936f9c00008aa8d79
😎 Deploy Preview	https://deploy-preview-16939--docs-eslint.netlify.app/maintain/manage-releases
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

bpmutter marked this pull request as draft

February 26, 2023 19:57

bpmutter commented

View reviewed changes

docs/src/maintain/index.md Outdated Show resolved Hide resolved

bpmutter commented

View reviewed changes

docs/src/maintain/manage-releases.md Outdated

-              A two-person release team is assigned to each scheduled release. This two-person team is responsible for:
+              A two-person release team is assigned to each scheduled release.
+              TODO: add a sentence or two about who the release team is composed of...just TSC members? how is the release team determined?

Contributor Author

bpmutter Mar 1, 2023

to reviewer: could you answer the question in the TODO?

Member

mdjermanovic Mar 1, 2023

Yes, just TSC members. Actually, one TSC member as we no longer have two-person teams for releases, just one person. Determined in the TSC meeting day before the release.

Contributor Author

bpmutter Mar 5, 2023

udpated to refere to 'release manager' instead of 'release team' throughout PR

bpmutter commented

View reviewed changes

docs/src/maintain/manage-releases.md Outdated Show resolved Hide resolved


          Apply suggestions from code review

6fc27b4

bpmutter marked this pull request as ready for review

March 1, 2023 02:09

amareshsm reviewed

View reviewed changes

docs/src/maintain/manage-issues.md Outdated Show resolved Hide resolved

nzakas approved these changes

View reviewed changes

Member

nzakas left a comment

Overall looks pretty good. Just left one suggestion.

docs/src/maintain/working-groups.md Outdated Show resolved Hide resolved


          Apply suggestions from code review

e6c0531

Co-authored-by: Amaresh  S M  <amareshsm13@gmail.com>
Co-authored-by: Nicholas C. Zakas <nicholas@humanwhocodes.com>

bpmutter commented

View reviewed changes

docs/src/maintain/manage-releases.md Outdated Show resolved Hide resolved

bpmutter added 3 commits

March 5, 2023 13:50


          Apply suggestions from code review

2c8f592


          release team -> release manager

62130fa


          1 more team --> manager

1525d2f

bpmutter requested a review from mdjermanovic

March 5, 2023 18:57

snitin315 added accepted and removed triage labels

snitin315 reviewed

View reviewed changes

Contributor

snitin315 left a comment

Overall looks good, few suggestions

docs/src/maintain/manage-issues.md Outdated Show resolved Hide resolved

docs/src/maintain/manage-releases.md Outdated Show resolved Hide resolved

docs/src/maintain/manage-releases.md Outdated Show resolved Hide resolved

mdjermanovic reviewed

View reviewed changes

docs/src/maintain/manage-releases.md Outdated

Comment on lines 46 to 48

		1. Update the release blog post with a "Highlights" section, including new rules and anything else that's important.
		1. Create a release blog post with a "Highlights" section, including new rules and anything else that's important.

Member

mdjermanovic Mar 6, 2023

Technically, it is "update", because the blog post is autogenerated.

Contributor Author

bpmutter Mar 10, 2023

fixed

bpmutter commented

View reviewed changes

docs/src/maintain/manage-releases.md Outdated Show resolved Hide resolved


          Apply suggestions from code review

9b41193

Co-authored-by: Nitin Kumar <snitin315@gmail.com>

bpmutter requested a review from mdjermanovic

March 10, 2023 01:35

mdjermanovic reviewed

View reviewed changes

docs/src/maintain/manage-releases.md Outdated Show resolved Hide resolved


          Update docs/src/maintain/manage-releases.md

da6523b

Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>

snitin315 approved these changes

View reviewed changes

Contributor

snitin315 left a comment •

edited

LGTM. Thanks!

Leaving it open for @mdjermanovic

snitin315 requested a review from mdjermanovic

March 12, 2023 01:34

mdjermanovic approved these changes

View reviewed changes

Member

mdjermanovic left a comment

LGTM, thanks!

mdjermanovic merged commit 3e1cf6b into eslint:main

17 checks passed

crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request


          Update dependency eslint to v8.37.0 (#1834)

20cd403

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [eslint](https://eslint.org) ([source](https://github.com/eslint/eslint)) | devDependencies | minor | [`8.36.0` -> `8.37.0`](https://renovatebot.com/diffs/npm/eslint/8.36.0/8.37.0) |

---

### Release Notes

<details>
<summary>eslint/eslint</summary>

### [`v8.37.0`](https://github.com/eslint/eslint/releases/tag/v8.37.0)

[Compare Source](eslint/eslint@v8.36.0...v8.37.0)

#### Features

-   [`b6ab8b2`](eslint/eslint@b6ab8b2) feat: `require-unicode-regexp` add suggestions ([#&#8203;17007](eslint/eslint#17007)) (Josh Goldberg)
-   [`10022b1`](eslint/eslint@10022b1) feat: Copy getScope() to SourceCode ([#&#8203;17004](eslint/eslint#17004)) (Nicholas C. Zakas)
-   [`1665c02`](eslint/eslint@1665c02) feat: Use plugin metadata for flat config serialization ([#&#8203;16992](eslint/eslint#16992)) (Nicholas C. Zakas)
-   [`b3634f6`](eslint/eslint@b3634f6) feat: docs license ([#&#8203;17010](eslint/eslint#17010)) (Samuel Roldan)
-   [`892e6e5`](eslint/eslint@892e6e5) feat: languageOptions.parser must be an object. ([#&#8203;16985](eslint/eslint#16985)) (Nicholas C. Zakas)

#### Bug Fixes

-   [`619f3fd`](eslint/eslint@619f3fd) fix: correctly handle `null` default config in `RuleTester` ([#&#8203;17023](eslint/eslint#17023)) (Brad Zacher)
-   [`1fbf118`](eslint/eslint@1fbf118) fix: `getFirstToken`/`getLastToken` on comment-only node ([#&#8203;16889](eslint/eslint#16889)) (Francesco Trotta)
-   [`129e252`](eslint/eslint@129e252) fix: Fix typo in `logical-assignment-operators` rule description ([#&#8203;17000](eslint/eslint#17000)) (Francesco Trotta)

#### Documentation

-   [`75339df`](eslint/eslint@75339df) docs: fix typos and missing info in id-match docs ([#&#8203;17029](eslint/eslint#17029)) (Ed Lucas)
-   [`ec2d830`](eslint/eslint@ec2d830) docs: Fix typos in the `semi` rule docs ([#&#8203;17012](eslint/eslint#17012)) (Andrii Lundiak)
-   [`e39f28d`](eslint/eslint@e39f28d) docs: add back to top button ([#&#8203;16979](eslint/eslint#16979)) (Tanuj Kanti)
-   [`721c717`](eslint/eslint@721c717) docs: Custom Processors cleanup and expansion ([#&#8203;16838](eslint/eslint#16838)) (Ben Perlmutter)
-   [`d049f97`](eslint/eslint@d049f97) docs: 'How ESLint is Maintained' page ([#&#8203;16961](eslint/eslint#16961)) (Ben Perlmutter)
-   [`5251a92`](eslint/eslint@5251a92) docs: Describe guard options for guard-for-in ([#&#8203;16986](eslint/eslint#16986)) (alope107)
-   [`6157d81`](eslint/eslint@6157d81) docs: Add example to guard-for-in docs. ([#&#8203;16983](eslint/eslint#16983)) (alope107)
-   [`fd47998`](eslint/eslint@fd47998) docs: update `Array.prototype.toSorted` specification link ([#&#8203;16982](eslint/eslint#16982)) (Milos Djermanovic)
-   [`3e1cf6b`](eslint/eslint@3e1cf6b) docs: Copy edits on Maintain ESLint docs ([#&#8203;16939](eslint/eslint#16939)) (Ben Perlmutter)

#### Chores

-   [`c67f299`](eslint/eslint@c67f299) chore: upgrade [@&#8203;eslint/js](https://github.com/eslint/js)[@&#8203;8](https://github.com/8).37.0 ([#&#8203;17033](eslint/eslint#17033)) (Milos Djermanovic)
-   [`ee9ddbd`](eslint/eslint@ee9ddbd) chore: package.json update for [@&#8203;eslint/js](https://github.com/eslint/js) release (ESLint Jenkins)
-   [`dddb475`](eslint/eslint@dddb475) chore: upgrade [@&#8203;eslint/eslintrc](https://github.com/eslint/eslintrc)[@&#8203;2](https://github.com/2).0.2 ([#&#8203;17032](eslint/eslint#17032)) (Milos Djermanovic)
-   [`522431e`](eslint/eslint@522431e) chore: upgrade espree@9.5.1 ([#&#8203;17031](eslint/eslint#17031)) (Milos Djermanovic)
-   [`f5f9a88`](eslint/eslint@f5f9a88) chore: upgrade eslint-visitor-keys@3.4.0 ([#&#8203;17030](eslint/eslint#17030)) (Milos Djermanovic)
-   [`4dd8d52`](eslint/eslint@4dd8d52) ci: bump actions/stale from 7 to 8 ([#&#8203;17026](eslint/eslint#17026)) (dependabot\[bot])
-   [`ad9dd6a`](eslint/eslint@ad9dd6a) chore: remove duplicate scss, ([#&#8203;17005](eslint/eslint#17005)) (Strek)
-   [`ada6a3e`](eslint/eslint@ada6a3e) ci: unpin Node 19 ([#&#8203;16993](eslint/eslint#16993)) (Milos Djermanovic)
-   [`c3da975`](eslint/eslint@c3da975) chore: Remove triage label from template ([#&#8203;16990](eslint/eslint#16990)) (Nicholas C. Zakas)
-   [`69bc0e2`](eslint/eslint@69bc0e2) ci: pin Node 19 to 19.7.0 ([#&#8203;16987](eslint/eslint#16987)) (Milos Djermanovic)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4yNC41IiwidXBkYXRlZEluVmVyIjoiMzUuMjQuNSJ9-->

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1834
Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

github-actions bot mentioned this pull request

Upgraded some dependencies - Attempt 2 AurorNZ/report-updated-dependencies#638

Merged

eslint-github-bot bot locked and limited conversation to collaborators

eslint-github-bot bot added the archived due to age label

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.