perf: optimize text-table by replacing regex with trimEnd (#19061)

* perf: optimize `text-table` by replacing regex with `trimEnd`

* chore: remove unwanted code & change file location

* refactor: remove unwanted code

* refactor: remove unwanted code

* chore: udpate eslint config

* fix: table formatting

Author: snitin315

lib/cli-engine/formatters/stylish.js

@@ -6,7 +6,7 @@
 
 const chalk = require("chalk"),
     util = require("node:util"),
-    table = require("text-table");
+    table = require("../../shared/text-table");
 
 //------------------------------------------------------------------------------
 // Helpers
@@ -62,8 +62,8 @@ module.exports = function(results) {
 
                 return [
                     "",
-                    message.line || 0,
-                    message.column || 0,
+                    String(message.line || 0),
+                    String(message.column || 0),
                     messageType,
                     message.message.replace(/([^ ])\.$/u, "$1"),
                     chalk.dim(message.ruleId || "")

lib/shared/text-table.js

@@ -0,0 +1,67 @@
+/**
+ * @fileoverview Optimized version of the `text-table` npm module to improve performance by replacing inefficient regex-based
+ * whitespace trimming with a modern built-in method.
+ *
+ * This modification addresses a performance issue reported in https://github.com/eslint/eslint/issues/18709
+ *
+ * The `text-table` module is published under the MIT License. For the original source, refer to:
+ * https://www.npmjs.com/package/text-table.
+ */
+
+/*
+ *
+ * This software is released under the MIT license:
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy of
+ * this software and associated documentation files (the "Software"), to deal in
+ * the Software without restriction, including without limitation the rights to
+ * use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of
+ * the Software, and to permit persons to whom the Software is furnished to do so,
+ * subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in all
+ * copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
+ * FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
+ * COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER
+ * IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
+ * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+ */
+
+"use strict";
+
+module.exports = function(rows_, opts) {
+    const hsep = "  ";
+    const align = opts.align;
+    const stringLength = opts.stringLength;
+
+    const sizes = rows_.reduce((acc, row) => {
+        row.forEach((c, ix) => {
+            const n = stringLength(c);
+
+            if (!acc[ix] || n > acc[ix]) {
+                acc[ix] = n;
+            }
+        });
+        return acc;
+    }, []);
+
+    return rows_
+        .map(row =>
+            row
+                .map((c, ix) => {
+                    const n = sizes[ix] - stringLength(c) || 0;
+                    const s = Array(Math.max(n + 1, 1)).join(" ");
+
+                    if (align[ix] === "r") {
+                        return s + c;
+                    }
+
+                    return c + s;
+                })
+                .join(hsep)
+                .trimEnd())
+        .join("\n");
+};

package.json

@@ -130,8 +130,7 @@
     "lodash.merge": "^4.6.2",
     "minimatch": "^3.1.2",
     "natural-compare": "^1.4.0",
-    "optionator": "^0.9.3",
-    "text-table": "^0.2.0"
+    "optionator": "^0.9.3"
   },
   "devDependencies": {
     "@arethetypeswrong/cli": "^0.16.4",