From 181bdd33a56a65d8627d57065cf647de9c21c44e Mon Sep 17 00:00:00 2001 From: Joel Mathew Koshy Date: Fri, 27 Oct 2023 13:18:52 -0400 Subject: [PATCH] Added suggestions:null for test cases that will not provide a suggestion. --- tests/lib/rules/no-console.js | 96 +++++++++++++++++++---------------- 1 file changed, 51 insertions(+), 45 deletions(-) diff --git a/tests/lib/rules/no-console.js b/tests/lib/rules/no-console.js index dea3cf74fd55..0ea029267937 100644 --- a/tests/lib/rules/no-console.js +++ b/tests/lib/rules/no-console.js @@ -40,6 +40,22 @@ ruleTester.run("no-console", rule, { invalid: [ // no options + { + code: "if (a) console.warn(foo)", + errors: [{ + messageId: "unexpected", + type: "MemberExpression", + suggestions: null + }] + }, + { + code: "foo(console.log)", + errors: [{ + messageId: "unexpected", + type: "MemberExpression", + suggestions: null + }] + }, { code: "console.log(foo)", errors: [{ @@ -113,34 +129,38 @@ ruleTester.run("no-console", rule, { }] }, { - code: "if (a) console.warn(foo)", + code: "class A { static { console.info(foo) } }", + parserOptions: { ecmaVersion: "latest" }, errors: [{ messageId: "unexpected", - type: "MemberExpression" + type: "MemberExpression", + suggestions: [{ + messageId: "removeConsole", + data: { propertyName: "info" }, + output: "class A { static { } }" + }] }] }, + + // one option { - code: "foo(console.log)", + code: "if (a) console.info(foo)", + options: [{ allow: ["warn"] }], errors: [{ messageId: "unexpected", - type: "MemberExpression" + type: "MemberExpression", + suggestions: null }] }, { - code: "class A { static { console.info(foo) } }", - parserOptions: { ecmaVersion: "latest" }, + code: "foo(console.warn)", + options: [{ allow: ["log"] }], errors: [{ messageId: "unexpected", type: "MemberExpression", - suggestions: [{ - messageId: "removeConsole", - data: { propertyName: "info" }, - output: "class A { static { } }" - }] + suggestions: null }] }, - - // one option { code: "console.log(foo)", options: [{ allow: ["error"] }], @@ -219,22 +239,6 @@ ruleTester.run("no-console", rule, { }] }] }, - { - code: "if (a) console.info(foo)", - options: [{ allow: ["warn"] }], - errors: [{ - messageId: "unexpected", - type: "MemberExpression" - }] - }, - { - code: "foo(console.warn)", - options: [{ allow: ["log"] }], - errors: [{ - messageId: "unexpected", - type: "MemberExpression" - }] - }, { code: "class A { static { console.error(foo) } }", options: [{ allow: ["log"] }], @@ -251,6 +255,24 @@ ruleTester.run("no-console", rule, { }, // multiple options + { + code: "if (a) console.log(foo)", + options: [{ allow: ["warn", "error"] }], + errors: [{ + messageId: "unexpected", + type: "MemberExpression", + suggestions: null + }] + }, + { + code: "foo(console.info)", + options: [{ allow: ["warn", "error"] }], + errors: [{ + messageId: "unexpected", + type: "MemberExpression", + suggestions: null + }] + }, { code: "console.log(foo)", options: [{ allow: ["warn", "info"] }], @@ -329,22 +351,6 @@ ruleTester.run("no-console", rule, { }] }] }, - { - code: "if (a) console.log(foo)", - options: [{ allow: ["warn", "error"] }], - errors: [{ - messageId: "unexpected", - type: "MemberExpression" - }] - }, - { - code: "foo(console.info)", - options: [{ allow: ["warn", "error"] }], - errors: [{ - messageId: "unexpected", - type: "MemberExpression" - }] - }, { code: "class A { static { console.info(foo) } }", options: [{ allow: ["log", "error", "warn"] }],