Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: drop eslint < 8 & Node.js < 18 #238

Merged
merged 3 commits into from
Feb 29, 2024
Merged

Conversation

aladdin-add
Copy link
Member

No description provided.

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are going to drop ESLint <8, then the README also needs to be updated.

@mdjermanovic mdjermanovic changed the title feat!: drop eslint <8 & node.js < 18 feat!: drop eslint <8 & Node.js < 18 Feb 27, 2024
@mdjermanovic mdjermanovic changed the title feat!: drop eslint <8 & Node.js < 18 feat!: drop eslint < 8 & Node.js < 18 Feb 27, 2024
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Leaving open for @nzakas to verify.

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@nzakas nzakas merged commit f14f6a5 into main Feb 29, 2024
10 checks passed
@nzakas nzakas deleted the feat/drop-eslint-and-node branch February 29, 2024 21:33
@github-actions github-actions bot mentioned this pull request Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants