Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(configs): member-delimiter-style should use semi delimiters when semi is true, fixes #266 #267

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

IGx89
Copy link
Contributor

@IGx89 IGx89 commented Jan 16, 2024

Description

Fixes #266 by adjusting the member-delimiter-style rule to use semicolon delimiters when semi is true.

Linked Issues

#266

Additional context

Copy link

netlify bot commented Jan 16, 2024

Deploy Preview for eslint-stylistic ready!

Name Link
🔨 Latest commit dfddd03
🔍 Latest deploy log https://app.netlify.com/sites/eslint-stylistic/deploys/65a6fcc78c7b4d000869c3d2
😎 Deploy Preview https://deploy-preview-267--eslint-stylistic.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@antfu antfu enabled auto-merge January 17, 2024 09:31
@antfu antfu added this pull request to the merge queue Jan 17, 2024
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0ef56c7) 99.79% compared to head (dfddd03) 99.79%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #267   +/-   ##
=======================================
  Coverage   99.79%   99.79%           
=======================================
  Files         113      113           
  Lines       26524    26524           
  Branches     4454     4454           
=======================================
  Hits        26470    26470           
  Misses         54       54           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into eslint-stylistic:main with commit 7701a2a Jan 17, 2024
13 checks passed
@IGx89 IGx89 deleted the IGx89/issue-266 branch January 17, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shared config: setting semi: true has no effect on member-delimiter-style
2 participants