Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(prefer-immutable-types)!: use suggestions instead of a fixer by default #598

Merged
merged 1 commit into from Mar 31, 2023

Conversation

RebeccaStevens
Copy link
Collaborator

@RebeccaStevens RebeccaStevens commented Mar 22, 2023

BREAKING CHANGE: The fixer config no longer inherits as many options as before; be sure to be
explicit in your configs.

fix #576

@RebeccaStevens RebeccaStevens added the Breaking Change This change will require a new major release. label Mar 22, 2023
@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Merging #598 (0ee8476) into main (f441a12) will increase coverage by 0.22%.
The diff coverage is 88.23%.

@@            Coverage Diff             @@
##             main     #598      +/-   ##
==========================================
+ Coverage   90.83%   91.06%   +0.22%     
==========================================
  Files          45       45              
  Lines        1211     1242      +31     
  Branches      313      313              
==========================================
+ Hits         1100     1131      +31     
+ Misses         50       49       -1     
- Partials       61       62       +1     
Flag Coverage Δ
4.0.2 90.98% <88.23%> (+0.23%) ⬆️
JS 90.82% <88.23%> (+0.23%) ⬆️
latest 90.82% <88.23%> (+0.23%) ⬆️
next 90.82% <88.23%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/rules/prefer-immutable-types.ts 90.56% <88.23%> (+2.28%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@RebeccaStevens RebeccaStevens changed the title feat(prefer-immutable-types): add support for suggestions feat(prefer-immutable-types)!: use suggestions instead of a fixer by default Mar 27, 2023
…default

BREAKING CHANGE: The fixer config no longer inherits as many options as before; be sure to be
explicit in your configs.
@RebeccaStevens RebeccaStevens changed the base branch from main to next March 31, 2023 03:49
@RebeccaStevens RebeccaStevens merged commit ba7d855 into next Mar 31, 2023
22 checks passed
@RebeccaStevens RebeccaStevens deleted the suggestions branch March 31, 2023 03:50
RebeccaStevens added a commit that referenced this pull request Jul 14, 2023
…default (#598)

BREAKING CHANGE: The fixer config no longer inherits as many options as before; be sure to be
explicit in your configs.
github-actions bot pushed a commit that referenced this pull request Jul 15, 2023
# [6.0.0-next.1](v5.0.8...v6.0.0-next.1) (2023-07-15)

### Bug Fixes

* further updates for v6 ([71ecdb5](71ecdb5))
* migrate code for [@typescript-eslint](https://github.com/typescript-eslint) v6 ([5c6b1a2](5c6b1a2))

### Build System

* increase minimum supported TypeScript version to 4.3.5 ([aefe6b2](aefe6b2))

### Features

* **prefer-immutable-types:** use suggestions instead of a fixer by default ([#598](#598)) ([3fb9028](3fb9028))
* remove `assumeTypes` option ([6be5862](6be5862))

### BREAKING CHANGES

* increase minimum supported TypeScript version to 4.3.5
* remove `assumeTypes` option
* **prefer-immutable-types:** The fixer config no longer inherits as many options as before; be sure to be
explicit in your configs.
github-actions bot pushed a commit that referenced this pull request Jul 30, 2023
# [6.0.0](v5.0.8...v6.0.0) (2023-07-30)

### Bug Fixes

* add sanity checks to type immutablity override settings ([d3ce5b0](d3ce5b0))
* further updates for v6 ([71ecdb5](71ecdb5))
* **immutable-data:** rework logic, it should work now ([9644994](9644994)), closes [#692](#692)
* migrate code for [@typescript-eslint](https://github.com/typescript-eslint) v6 ([5c6b1a2](5c6b1a2))
* replace `ignorePattern` option with `ignoreIdentifierPattern` and `ignoreCodePattern` ([48d8eba](48d8eba)), closes [#467](#467)

### Build System

* increase minimum supported TypeScript version to 4.3.5 ([aefe6b2](aefe6b2))

### Features

* **functional-parameters:** add option to ignore getters and setters ([9c89b9e](9c89b9e))
* **immutable-data:** add new option `ignoreNonConstDeclarations` ([ecde24a](ecde24a)), closes [#691](#691)
* **no-expression-statements:** add option to ignore self returning functions ([894fb91](894fb91)), closes [#611](#611)
* **prefer-immutable-types:** use suggestions instead of a fixer by default ([#598](#598)) ([3fb9028](3fb9028))
* remove `assumeTypes` option ([6be5862](6be5862))

### BREAKING CHANGES

* replace `ignorePattern` option with `ignoreIdentifierPattern` and `ignoreCodePattern`
* increase minimum supported TypeScript version to 4.3.5
* remove `assumeTypes` option
* **prefer-immutable-types:** The fixer config no longer inherits as many options as before; be sure to be
explicit in your configs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change This change will require a new major release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

functional/prefer-immutable-types use suggestions instead of fixer
1 participant