Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename ignorePattern #467

Closed
RebeccaStevens opened this issue Sep 7, 2022 · 4 comments · Fixed by #683
Closed

Rename ignorePattern #467

RebeccaStevens opened this issue Sep 7, 2022 · 4 comments · Fixed by #683
Labels
Breaking Change This change will require a new major release. Status: Beta Released It's now live. Status: Released It's now live. Type: Enhancement Enhancement of the code, not introducing new features.

Comments

@RebeccaStevens
Copy link
Collaborator

ignorePattern is only used against identifiers (such as function/variable names) so maybe a better name would be something like ignoreIdentifiers or ignoreNames.
@RebeccaStevens RebeccaStevens added Type: Enhancement Enhancement of the code, not introducing new features. Breaking Change This change will require a new major release. labels Sep 7, 2022
@RebeccaStevens
Copy link
Collaborator Author

@jonaskello Do you have any thoughts on this?

@RebeccaStevens
Copy link
Collaborator Author

Closing for now as it didn't make the cut for v5

@RebeccaStevens RebeccaStevens closed this as not planned Won't fix, can't repro, duplicate, stale Jan 29, 2023
@RebeccaStevens RebeccaStevens mentioned this issue Mar 26, 2023
Closed
RebeccaStevens added a commit that referenced this issue Jul 21, 2023
@RebeccaStevens
fix!: replace ignorePattern option with ignoreIdentifierPattern a…
48d8eba 
…nd `ignoreCodePattern`

fix #467
@RebeccaStevens RebeccaStevens mentioned this issue Jul 21, 2023
Merged
github-actions bot pushed a commit that referenced this issue Jul 21, 2023
@semantic-release-bot
chore(release): 6.0.0-next.5 [skip ci]
180e191 
# [6.0.0-next.5](v6.0.0-next.4...v6.0.0-next.5) (2023-07-21)

### Bug Fixes

* replace `ignorePattern` option with `ignoreIdentifierPattern` and `ignoreCodePattern` ([48d8eba](48d8eba)), closes [#467](#467)

### BREAKING CHANGES

* replace `ignorePattern` option with `ignoreIdentifierPattern` and `ignoreCodePattern`
@github-actions
Copy link

🎉 This issue has been resolved in version 6.0.0-next.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the Status: Beta Released It's now live. label Jul 21, 2023
RebeccaStevens added a commit that referenced this issue Jul 30, 2023
@RebeccaStevens
Merge pull request #683 from eslint-functional/next
103d3a4 
close #599
close #678
fix #467
fix #576
fix #577
fix #611
fix #675
fix #691
fix #692
github-actions bot pushed a commit that referenced this issue Jul 30, 2023
@semantic-release-bot
chore(release): 6.0.0 [skip ci]
27db8bf 
# [6.0.0](v5.0.8...v6.0.0) (2023-07-30)

### Bug Fixes

* add sanity checks to type immutablity override settings ([d3ce5b0](d3ce5b0))
* further updates for v6 ([71ecdb5](71ecdb5))
* **immutable-data:** rework logic, it should work now ([9644994](9644994)), closes [#692](#692)
* migrate code for [@typescript-eslint](https://github.com/typescript-eslint) v6 ([5c6b1a2](5c6b1a2))
* replace `ignorePattern` option with `ignoreIdentifierPattern` and `ignoreCodePattern` ([48d8eba](48d8eba)), closes [#467](#467)

### Build System

* increase minimum supported TypeScript version to 4.3.5 ([aefe6b2](aefe6b2))

### Features

* **functional-parameters:** add option to ignore getters and setters ([9c89b9e](9c89b9e))
* **immutable-data:** add new option `ignoreNonConstDeclarations` ([ecde24a](ecde24a)), closes [#691](#691)
* **no-expression-statements:** add option to ignore self returning functions ([894fb91](894fb91)), closes [#611](#611)
* **prefer-immutable-types:** use suggestions instead of a fixer by default ([#598](#598)) ([3fb9028](3fb9028))
* remove `assumeTypes` option ([6be5862](6be5862))

### BREAKING CHANGES

* replace `ignorePattern` option with `ignoreIdentifierPattern` and `ignoreCodePattern`
* increase minimum supported TypeScript version to 4.3.5
* remove `assumeTypes` option
* **prefer-immutable-types:** The fixer config no longer inherits as many options as before; be sure to be
explicit in your configs.
@github-actions
Copy link

🎉 This issue has been resolved in version 6.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the Status: Released It's now live. label Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Breaking Change This change will require a new major release. Status: Beta Released It's now live. Status: Released It's now live. Type: Enhancement Enhancement of the code, not introducing new features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Next Release eslint-functional/eslint-plugin-functional
1 participant
@RebeccaStevens