From 6cf016fbd1ce4dc109c4f330dc15ae73a5ac5793 Mon Sep 17 00:00:00 2001 From: Nick Schonning Date: Wed, 28 Sep 2022 21:13:19 -0400 Subject: [PATCH 1/2] fix: minor typos --- CHANGELOG.md | 2 +- __tests__/no-promise-in-callback.js | 2 +- docs/rules/no-callback-in-promise.md | 2 +- rules/no-native.js | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3e40cb4a..9b924c9d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -38,7 +38,7 @@ ## 4.3.0 - https://github.com/eslint-community/eslint-plugin-promise/pull/202 -- Udpated jest +- Updated jest ## 4.2.2 diff --git a/__tests__/no-promise-in-callback.js b/__tests__/no-promise-in-callback.js index 61086e15..37830c3e 100644 --- a/__tests__/no-promise-in-callback.js +++ b/__tests__/no-promise-in-callback.js @@ -20,7 +20,7 @@ ruleTester.run('no-promise-in-callback', rule, { // arrow functions and other things 'go(() => Promise.resolve(4))', 'go((errrr) => a.then(b))', - 'go((elpers) => { b.catch(c) })', + 'go((helpers) => { b.catch(c) })', 'go((e) => { b.then(c, d) })', // within promises it won't complain diff --git a/docs/rules/no-callback-in-promise.md b/docs/rules/no-callback-in-promise.md index 75c4136a..a86c4b1a 100644 --- a/docs/rules/no-callback-in-promise.md +++ b/docs/rules/no-callback-in-promise.md @@ -53,7 +53,7 @@ Callback got called with: null data ``` Finally, if your callbacks have a Node.js signature (i.e. -`callback(err, data)`), consider using [util.promsify] for promisifying your +`callback(err, data)`), consider using [util.promisify] for promisifying your callback code instead of combining the approaches. [util.promisify]: diff --git a/rules/no-native.js b/rules/no-native.js index b77716eb..fa96be7d 100644 --- a/rules/no-native.js +++ b/rules/no-native.js @@ -38,7 +38,7 @@ module.exports = { /** * Checks for and reports reassigned constants * - * @param {Scope} scope - an escope Scope object + * @param {Scope} scope - an scope Scope object * @returns {void} * @private */ From c8ed1c4b442fa32b3497b89269fe1f8855f1dc2a Mon Sep 17 00:00:00 2001 From: Nick Schonning Date: Thu, 29 Sep 2022 00:08:33 -0400 Subject: [PATCH 2/2] Update rules/no-native.js Co-authored-by: Yosuke Ota --- rules/no-native.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rules/no-native.js b/rules/no-native.js index fa96be7d..6c37a448 100644 --- a/rules/no-native.js +++ b/rules/no-native.js @@ -38,7 +38,7 @@ module.exports = { /** * Checks for and reports reassigned constants * - * @param {Scope} scope - an scope Scope object + * @param {Scope} scope - an eslint-scope Scope object * @returns {void} * @private */