Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(always-return): add ignoreLastCallback option #365

Merged
merged 2 commits into from Oct 1, 2022
Merged

feat(always-return): add ignoreLastCallback option #365

merged 2 commits into from Oct 1, 2022

Conversation

ota-meshi
Copy link
Member

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • New rule
  • Changes an existing rule
  • Add autofixing to a rule
  • Other, please explain:

What changes did you make? (Give an overview)

This PR adds ignoreLastCallback option to always-return rule.

If ignoreLastCallback: true, the last then() callback in a promise chain does not warn if it does not have a return.

close #59

MichaelDeBoey
MichaelDeBoey approved these changes Sep 30, 2022
View reviewed changes
__tests__/always-return.js Show resolved Hide resolved
docs/rules/always-return.md Show resolved Hide resolved
@MichaelDeBoey MichaelDeBoey merged commit 01def31 into main Oct 1, 2022
@MichaelDeBoey MichaelDeBoey deleted the always-return-option branch October 1, 2022 18:16
@github-actions
Copy link

🎉 This PR is included in version 6.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelDeBoey MichaelDeBoey MichaelDeBoey approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

always-return should ignore the last then
2 participants
@ota-meshi @MichaelDeBoey