chore: minor typos #359
Merged
chore: minor typos #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nschonni
commented
Sep 29, 2022
| @@ -20,7 +20,7 @@ ruleTester.run('no-promise-in-callback', rule, { | |||
| // arrow functions and other things | |||
| 'go(() => Promise.resolve(4))', | |||
| 'go((errrr) => a.then(b))', | |||
There was a problem hiding this comment.
Not sure why the testing was unhappy when I tried changing this to err/error/errr, but I reverted it
Message:
Should have no errors but had 1: [
{
ruleId: 'no-promise-in-callback',
severity: 1,
message: 'Avoid using promises inside of callbacks.',
line: 1,
column: 13,
nodeType: 'MemberExpression',
endLine: 1,
endColumn: 19
}
]
ota-meshi
requested changes
Sep 29, 2022
Co-authored-by: Yosuke Ota <otameshiyo23@gmail.com>
|
🎉 This PR is included in version 6.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
What changes did you make? (Give an overview)
Used cSpell to find a few minor typos