Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing import recognise tsx extension #97

Merged
merged 1 commit into from May 10, 2023

Conversation

neviaumi
Copy link

As a caption.

When i try to import tsx file extension from file.

the js extension won't working

Copy link

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add the .idea/* to gitignore, otherwise LGTM, thanks!

@neviaumi
Copy link
Author

@aladdin-add updated according your comments.

Please check again :)

@aladdin-add aladdin-add merged commit 5fae8a5 into eslint-community:master May 10, 2023
8 of 9 checks passed
@aladdin-add
Copy link

released in v16.0.0-1: https://github.com/eslint-community/eslint-plugin-n/releases/tag/16.0.0-1

please note it's a pre-release as I was preparing a major.

Copy link

@jaydenseric jaydenseric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't correct to map .tsx to .jsx, most TypeScript projects compile .tsx to .js. It depends on if the project TypeScript config has jsx configured to "preserve" or not:

Edit: Sorry, I'm just now noticing there is an issue and PR about it: #108 #112

@aladdin-add
Copy link

aladdin-add commented Sep 1, 2023

@jaydenseric can you please file a new issue to discuss it?

agreed it's not ideal to guess the actual tsconfig. If we are not able to know it, I prefer not having the default - unless it was explicitly configured; while it seems a breaking change. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants