Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: no-unpublished-import supports ignoreTypeImport (fixes #78) #79

Merged
merged 2 commits into from Mar 3, 2023

Conversation

Toilal
Copy link

@Toilal Toilal commented Jan 16, 2023

#78

Copy link

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking adding a preset for ts users. so can we make it to be an option, so we can enable it in the preset later.

also, can you add a few tests? thanks!

@Toilal
Copy link
Author

Toilal commented Jan 17, 2023

Yes, I need to bring typescript-eslint into devDependencies to add some TypeScript tests no problem with this ?

@aladdin-add
Copy link

I need to bring typescript-eslint into devDependencies to add some TypeScript tests no problem with this

👍 sgtm!

@aladdin-add aladdin-add changed the title fix: skip import type nodes in no-unpublished-import rule (#78) feat: no-unpublished-import supports ignoreTypeImport (fixes #78) Feb 8, 2023
@aladdin-add
Copy link

I don't think it's a bugfix, so I'd prefer putting it behind an option (temp naming ignoreTypeImport).

just pushed a very simple commit, and I'll be back to finish it and release a new version soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants