Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-unspported-features support new added node.js globals #35

Closed
aladdin-add opened this issue Jul 15, 2022 · 4 comments
Closed

no-unspported-features support new added node.js globals #35

aladdin-add opened this issue Jul 15, 2022 · 4 comments

Comments

@aladdin-add
Copy link

e.g. fetch: requires node.js >= 18.0.0

kevinoid added a commit to kevinoid/eslint-config-kevinoid that referenced this issue Oct 20, 2023
Since eslint-plugin-n doesn't define recent globals like fetch
eslint-community/eslint-plugin-n#35
we must either define them or enable the node env to get them
automatically.  Re-enable until eslint-plugin-n catches up.

Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
@scagood
Copy link

scagood commented Jan 10, 2024

We now use eslint-plugin-es-x. Is this issue resolved? 👀

@aladdin-add
Copy link
Author

not yet. fetch was enabled in globals, but the rule no-unspported-features needs to report if it was not supported in the given node.js versions: https://github.com/eslint-community/eslint-plugin-n/blob/master/lib/rules/no-unsupported-features/node-builtins.js#L17C15-L26

@scagood
Copy link

scagood commented Jan 12, 2024

I wonder if we should try to pull this information from https://nodejs.org/api/all.json

I can't imagine it'd be too hard to convert the basic data. The deprecations and experimental data may be a little harder.

@scagood
Copy link

scagood commented Feb 6, 2024

This can be closed (I hope 😅) due to #174

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants