Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rule shebang naming #196

Closed
1 task done
aladdin-add opened this issue Mar 4, 2024 · 8 comments · Fixed by #198 or #176
Closed
1 task done

rule shebang naming #196

aladdin-add opened this issue Mar 4, 2024 · 8 comments · Fixed by #198 or #176

Comments

@aladdin-add
Copy link

eslint-plugin-n version

latest

What problem do you want to solve?

In the description of the es specification, it is hashbang and not shebang.

https://github.com/tc39/proposal-hashbang

What do you think is the correct solution?

renaming rule shebang => hashbang.

for compat, we could keep shebang as an alias.

Participation

  • I am willing to submit a pull request for this change.

Additional comments

No response

@scagood
Copy link

scagood commented Mar 4, 2024

I think you're right, we should follow the spec, that being said, I only really knew this as a shebang. I don't like the idea of using an alias though, I would prefer we only used either hashbang or shebang 👀

What do you think?

@aladdin-add
Copy link
Author

I prefer to maintain compatibility if it doesn't come with too many maintenance costs :).

@scagood
Copy link

scagood commented Mar 4, 2024

That makes sense to me :)

@mrhyde
Copy link

mrhyde commented Apr 8, 2024

Hey, sorry for being late on this, but maybe someone else is wondering the same thing I was "WTH is hashbang?".

I have no idea what TC39 were smoking when they let a dude with zero GitHub activity reach stage 4 but the #! thing has always been called a 'SHeBang' since 1980.
Even Google will try to correct you if you type something like "script hashbang".
So yeah, this was definitely a rushed change...

@aladdin-add
Copy link
Author

It may indeed be controversial, but we should still follow the terminology of tc39.

@mrhyde
Copy link

mrhyde commented Apr 8, 2024

https://github.com/tc39/proposal-hashbang?tab=readme-ov-file#why-hashbang-instead-of-shebang

https://en.wikipedia.org/wiki/Shebang_(Unix)

Being approved by TC39 does not automatically make it the correct choice. People make mistakes, and this is one example of such a case.

@aladdin-add
Copy link
Author

aladdin-add commented Apr 8, 2024

As of now, I'm not sure what's the right next step, butshebang was not (and will not be) removed, it's now an alias of hashbang, so you can keep using it. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants